Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to the conversion_hosts table #335

Merged
merged 4 commits into from
Feb 14, 2019
Merged

Add comments to the conversion_hosts table #335

merged 4 commits into from
Feb 14, 2019

Conversation

djberg96
Copy link
Contributor

In my continuing effort to understand things better by documenting them, this is my attempt to document the conversion_hosts table.

One question arose which is what is the effective difference between max_concurrent_tasks and concurrent_transformation_limit.

Feedback and suggestions welcome.

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that fails when any new columns are added to the table and they don't have comments?

@djberg96
Copy link
Contributor Author

@bdunne I wouldn't know how to enforce it. I think that would require some sort of core migration change, wouldn't it?

@bdunne
Copy link
Member

bdunne commented Feb 13, 2019

Add a test to ensure that all columns are documented
@djberg96
Copy link
Contributor Author

@bdunne Didn't know about automated review. Looks good, merged it, thanks.

@miq-bot
Copy link
Member

miq-bot commented Feb 13, 2019

Checked commits https://github.com/djberg96/manageiq-schema/compare/991d23d0f6980b26196bf8d074179f1f0aa984bf~...3b8a1aeda59d21fe017cc191a029b3a7e8c91f24 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

spec/automated_review/column_documentation_spec.rb

@bdunne bdunne merged commit 130fc44 into ManageIQ:master Feb 14, 2019
@bdunne bdunne self-assigned this Feb 14, 2019
@bdunne bdunne added this to the Sprint 105 Ending Feb 18, 2019 milestone Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants