-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments to the conversion_hosts table #335
Conversation
db/migrate/20190213184307_add_comments_to_conversion_hosts_table.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that fails when any new columns are added to the table and they don't have comments?
@bdunne I wouldn't know how to enforce it. I think that would require some sort of core migration change, wouldn't it? |
@djberg96 https://github.com/djberg96/manageiq-schema/pull/1 Let me know what you think |
Add a test to ensure that all columns are documented
@bdunne Didn't know about automated review. Looks good, merged it, thanks. |
Checked commits https://github.com/djberg96/manageiq-schema/compare/991d23d0f6980b26196bf8d074179f1f0aa984bf~...3b8a1aeda59d21fe017cc191a029b3a7e8c91f24 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/automated_review/column_documentation_spec.rb
|
In my continuing effort to understand things better by documenting them, this is my attempt to document the
conversion_hosts
table.One question arose which is what is the effective difference between
max_concurrent_tasks
andconcurrent_transformation_limit
.Feedback and suggestions welcome.