Remove RSS table #343
Merged
Remove RSS table #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliancheal
force-pushed
the
deprecate_rss
branch
from
d787fbd
to
3e52a62
Compare
jrafanie
reviewed
Mar 11, 2019
| @@ -0,0 +1,5 @@ | |||
| class RemoveRssFeeds < ActiveRecord::Migration[5.0] | |||
| def change | |||
| drop_table :rss_feeds | |||
There was a problem hiding this comment.
The cop is complaining because this isn't reversible? If we don't want to put the table in the down migration, maybe we should write an up without a down.... but why not just recreate it as it is now in the down?
juliancheal
force-pushed
the
deprecate_rss
branch
from
3e52a62
to
1323511
Compare
juliancheal
force-pushed
the
deprecate_rss
branch
from
1323511
to
4b4e72a
Compare
|
Checked commit juliancheal@4b4e72a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20190301174502_remove_rss_feeds.rb
|
Presumably we can ignore this cop? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from ManageIQ/manageiq#18478