Remove serialization of non-existing classes/objects #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrafanie
commented
Jul 9, 2019
db/migrate/20190708192323_fix_unserializable_notification_options.rb
Outdated
Show resolved
Hide resolved
jrafanie
force-pushed
the
fix_unserializable_notification_options
branch
4 times, most recently
from
47e4e0f
to
5093aa6
Compare
bdunne
reviewed
Jul 10, 2019
db/migrate/20190708192323_fix_unserializable_notification_options.rb
Outdated
Show resolved
Hide resolved
Fryguy
reviewed
Jul 11, 2019
db/migrate/20190708192323_fix_unserializable_notification_options.rb
Outdated
Show resolved
Hide resolved
|
Is this solving two distinct issues or is there some relation between the serialization issue and the subject not existing? |
Yes, there are two distinct issues. In the database I had...
|
jrafanie
force-pushed
the
fix_unserializable_notification_options
branch
from
5093aa6
to
06ff77d
Compare
|
Ok, @bdunne @carbonin and I discussed this:
It seems best to just clear these bad options columns instead of trying to instantiate and possibly fix them. So, now we just mark them as "Unreadable" or Removed". |
jrafanie
changed the title
jrafanie
changed the title
jrafanie
force-pushed
the
fix_unserializable_notification_options
branch
from
06ff77d
to
115c90a
Compare
jrafanie
commented
Jul 16, 2019
db/migrate/20190708192323_fix_unserializable_notification_options.rb
Outdated
Show resolved
Hide resolved
jrafanie
changed the title
jrafanie
force-pushed
the
fix_unserializable_notification_options
branch
from
115c90a
to
8c6041b
Compare
carbonin
reviewed
Jul 17, 2019
db/migrate/20190708192323_fix_unserializable_notification_options.rb
Outdated
Show resolved
Hide resolved
Rails 5.0.0 - 5.0.6 serialized internal classes that don't exist in rails 5.1+. For example, ActiveModel::Type::Text was moved to ActiveRecord so anything that serialized the raw_attributes, which contain lots of bloated information, and this class was in the raw_attributes, we would be unable to deserialize it using rails 5.1+. Additionally, if the notificiation has a subject in the options column that no longer exists, therefore we have to also remove these. See also: rails/rails#25145
jrafanie
force-pushed
the
fix_unserializable_notification_options
branch
from
8c6041b
to
217f5c9
Compare
|
Checked commit jrafanie@217f5c9 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20190708192323_fix_unserializable_notification_options.rb
spec/migrations/20190708192323_fix_unserializable_notification_options_spec.rb
|
|
@jrafanie were you able to track down where we were creating a notification with an AR object in the |
|
@carbonin first one is from here (serialized classes that no longer exist): https://github.com/ManageIQ/manageiq-providers-openstack/blob/ac0b2d4283eb1e0ee98a03949416574674f16d6b/app/models/manageiq/providers/openstack/cloud_manager/vm/operations.rb#L13 second one is here (options[:subject] was removed): It's still a problem. It looks like it was added here and has never been changed. Note, the first notification (vm_destroy_success) has a subject (vm). the second one (cloud_volume_delete_success), doesn't. Note, I don't see them setting the subject association in most places. Does anyone work on openstack to fix this? I'm not sure if they're using |
|
@agrare do you know who we can ping about ☝️ ? |
|
@agrare to summarize: We have a |
|
ping @aufi ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 5.0.0 - 5.0.6 serialized internal classes that don't exist in rails
5.1+.
For example, ActiveModel::Type::Text was moved to ActiveRecord so
anything that serialized the raw_attributes, which contain lots of
bloated information, and this class was in the raw_attributes, we would
be unable to deserialize it using rails 5.1+.
Additionally, if the notificiation has a subject in the options column
that no longer exists, therefore we have to also remove these.
See also:
rails/rails#25145