Existing services should have a lifecycle state of provisioned #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
reviewed
Jul 12, 2019
d-m-u
force-pushed
the
updating_existing_services_lifecycle_state
branch
3 times, most recently
from
70a9bd7
to
c0c71ba
Compare
gmcculloug
approved these changes
Jul 12, 2019
lfu
reviewed
Jul 12, 2019
lpichler
approved these changes
Jul 15, 2019
…ey are provisioned
d-m-u
force-pushed
the
updating_existing_services_lifecycle_state
branch
from
c0c71ba
to
4e11cc4
Compare
|
Checked commit d-m-u@4e11cc4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20190712135032_set_provisioned_state_to_services.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any existing service that isn't retired but is provisioned should have a lifecycle state of provisioned.
I really wish this had been done as part of the earlier work for https://bugzilla.redhat.com/show_bug.cgi?id=1595511.
@tinaafitz @lfu @gmcculloug
This blocks ManageIQ/manageiq#18943
@jrafanie please review?