Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miq_worker_types table #437

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Conversation

carbonin
Copy link
Member

This table will be seeded to include all leaf subclasses of MiqWorker

On the first pass it will be a replacement for the information currently
stored in the MIQ_WORKER_TYPES constants, but will be extended to
contain all the metadata concerning when workers of each type should
be running (for example, required roles, worker scope, provider type, etc.)

The ultimate goal is to separate out worker management into a standalone
process distinct from the current code-base where a subset of models
will be the primary API between the "worker orchestrator" and the
server which will determine how to start the workers it was told
to run.

This will allow for sharing the core logic of when and where to run
workers across different platforms and runtimes such as systemd, fork,
containers, etc.

This table will be seeded to include all leaf subclasses of MiqWorker

On the first pass it will be a replacement for the information currently
stored in the MIQ_WORKER_TYPES constants, but will be extended to
contain all the metadata concerning when workers of each type should
be running (for example, required roles, worker scope, provider type, etc.)

The ultimate goal is to separate out worker management into a standalone
process distinct from the current code-base where a subset of models
will be the primary API between the "worker orchestrator" and the
server which will determine *how* to start the workers it was told
to run.

This will allow for sharing the core logic of when and where to run
workers across different platforms and runtimes such as systemd, fork,
containers, etc.
@miq-bot
Copy link
Member

miq-bot commented Nov 19, 2019

Checked commit carbonin@13c6bdf with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

db/migrate/20191115164358_create_miq_worker_types.rb

class CreateMiqWorkerTypes < ActiveRecord::Migration[5.1]
def change
create_table :miq_worker_types do |t|
t.string :worker_type, :null => false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Fryguy Fryguy merged commit 920de25 into ManageIQ:master Nov 21, 2019
@Fryguy Fryguy added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 21, 2019
@Fryguy Fryguy added the schema label Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants