Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expression to entitlements #47

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

imtayadeway
Copy link
Contributor

In support of https://www.pivotaltracker.com/story/show/148794877

@miq-bot add-label enhancement, core
@miq-bot assign @gtanzillo

@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2017

@imtayadeway Cannot apply the following label because they are not recognized: core

@Fryguy
Copy link
Member

Fryguy commented Aug 1, 2017

I'm wondering if this should be named filter_expression to make it clearer what the intent of the expression is. expression by itself seems too open ended.

@imtayadeway imtayadeway force-pushed the add-expression-to-entitlements branch from 1217c7f to 2c51aaf Compare August 1, 2017 18:33
@miq-bot
Copy link
Member

miq-bot commented Aug 1, 2017

Checked commit imtayadeway@2c51aaf with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy Fryguy merged commit 267c684 into ManageIQ:master Aug 2, 2017
@Fryguy Fryguy added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 2, 2017
@Fryguy Fryguy added the schema label Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants