Delete any worker records that have a JSON queue_name #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing miq_workers with a compound queue_name is a way to allow a worker to dequeue for multiple ext_management_systems at once, aka allowing an Amazon RefreshWorker to refresh the CloudManager and NetworkManager in the same worker. This has other side effects however including making it more difficult to find a worker by an EMS (e.g. when destroying the EMS) and requires that the base MiqWorker class do `JSON.parse(self[:queue_name]) rescue self[:queue_name]` Another option is to have the child managers report their queue_name for the refresh operation as the parent manager's queue_name.
2 tasks
|
Checked commit agrare@0c95def with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
agrare
changed the title
jrafanie
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing miq_workers with a compound queue_name is a way to allow a
worker to dequeue for multiple ext_management_systems at once, aka
allowing an Amazon RefreshWorker to refresh the CloudManager and
NetworkManager in the same worker.
This has other side effects however including making it more difficult
to find a worker by an EMS (e.g. when destroying the EMS) and requires
that the base MiqWorker class do
JSON.parse(self[:queue_name]) rescue self[:queue_name]Another option is to have the child managers report their queue_name for
the refresh operation as the parent manager's queue_name.
ManageIQ/manageiq#20345