Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relationship from sessions to users #503

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

gtanzillo
Copy link
Member

@miq-bot
Copy link
Member

miq-bot commented Aug 24, 2020

Checked commit gtanzillo@7692b74 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@@ -0,0 +1,5 @@
class AddUserToSessions < ActiveRecord::Migration[5.2]
def change
add_reference :sessions, :user
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify this creates a bigint column? We have other PRs where I'm not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just verified it in my local DB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the id column, int8

@Fryguy Fryguy merged commit a4b8317 into ManageIQ:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants