Rename TagMapping resource_type for Amazon Vms and Images #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
changed the title
6 tasks
|
Now that kasparov is branched off I'm going to un-wip this |
agrare
force-pushed
the
update_tag_mapper_labeled_resource_type
branch
from
ef13a74
to
b96f82c
Compare
lpichler
approved these changes
Nov 5, 2020
Fryguy
reviewed
Nov 6, 2020
| end | ||
|
|
||
| def up | ||
| ProviderTagMapping.where(:labeled_resource_type => "Vm").update_all(:labeled_resource_type => "VmAmazon") |
There was a problem hiding this comment.
Can you add a say_with_time on all of these?
Is this master only? |
The Amazon provider was the first cloud provider to participate in the (originally) ContainerLabelTagMapping class. It has since been expanded to include many providers including Openstack, Azure, and VMware vSphere. This means that the original labeled_resource_type of "Vm" and "Image" meaning Amazon VMs and Templates is quite confusing.
agrare
force-pushed
the
update_tag_mapper_labeled_resource_type
branch
from
b96f82c
to
e786e94
Compare
|
Checked commit agrare@e786e94 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint spec/migrations/20201022201901_update_amazon_tag_mapper_resource_type_spec.rb
|
|
@Fryguy correct we don't need this on kasparov |
|
LGTM...just needs the dependent PR to be ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Amazon provider was the first cloud provider to participate in the (originally) ContainerLabelTagMapping class. It has since been expanded to include many providers including Openstack, Azure, and VMware vSphere.
This means that the original labeled_resource_type of "Vm" and "Image" meaning Amazon VMs and Templates is quite confusing.
Follow-up to: ManageIQ/manageiq-providers-vmware#658 (comment)
Depends on: ManageIQ/manageiq-ui-classic#7438 ManageIQ/manageiq-providers-amazon#671