Drop unused pglogical references #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of ManageIQ/manageiq#18686 we moved from pglogical to the pg-logical_replication using postgresql's native logical replication. We switched as of ivanchuk. It should be safe to drop this now. Funny enough, this actually helps with getting ruby 3.0 support because the AR extension signature for drop_table needs to change to work with ruby 2.x and 3.x.
|
This also helps with getting us to GitHub Actions (in a way), because after this we can archive the pg-pglogical gem, which I can't get GitHub Actions working on anyway due to the need to mess with the database service: https://github.com/ManageIQ/pg-pglogical/blob/29f4667183d80d56611011cc152422f485a0ff47/ci/before_install.sh#L3-L9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of ManageIQ/manageiq#18686 we moved from pglogical
to the pg-logical_replication using postgresql's native logical replication.
We switched as of ivanchuk. It should be safe to drop this now.
Funny enough, this actually helps with getting ruby 3.0 support because the AR
extension signature for drop_table needs to change to work with ruby 2.x and
3.x.