Fix issue with showback_rate belongs and type of the data in steps let INFINITY #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aljesusg
commented
Sep 18, 2017
•
aljesusg
commented
- Change showback_rates to showback_rate => Error
- Change type of steps to float for let INFINITY value
|
@miq-bot add_label bug |
|
Checked commit aljesusg@80a2bfb with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 db/migrate/20170918190738_issue_shorback_tiers.rb
|
|
@gtanzillo @Fryguy |
jrafanie
reviewed
Sep 18, 2017
| def up | ||
| rename_column :showback_tiers, :showback_rates_id, :showback_rate_id | ||
| change_column :showback_tiers, :tier_start_value, :float | ||
| change_column :showback_tiers, :tier_end_value, :float |
There was a problem hiding this comment.
To be clear, the current chargeback uses floats and we mistakingly are using bigint here. We only really want to use Float for Float::INFINITY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.