Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MiddlewareServer to MiddlewareServerWildfly and MiddlewareServerEap #81

Merged
merged 5 commits into from
Oct 23, 2017
Merged

Migrate MiddlewareServer to MiddlewareServerWildfly and MiddlewareServerEap #81

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47df2bc
Migrate MiddlewareServer to MiddlewareServerWildfly
tumido Sep 28, 2017
53a8ce0
Filter just Wildfly/EAP
tumido Sep 29, 2017
484e799
Separate Wildfly and EAP
tumido Sep 29, 2017
3c3178a
Disable STI
tumido Sep 29, 2017
3f7ce44
Add spec to migration
tumido Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions db/migrate/20170928202851_migrate_middleware_server_to_wildfly_and_eap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
class MigrateMiddlewareServerToWildflyAndEap < ActiveRecord::Migration[5.0]
class MiddlewareServer < ApplicationRecord
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to add self.inheritance_column = :_type_disabled for this stub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class MiddlewareServer < ActiveRecord::Base

see details:
#4

end

def up
say_with_time('Migrating middleware_server to middleware_server_wildfly') do
MiddlewareServer
.where("type = ? AND product ~* ?", 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServer', 'wildfly')
.update_all(:type => 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServerWildfly')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the new wildfly/eap class be a subclass/subtype of middleware server class? here it seems it's in hierarchy of middleware_manager, or I am probably missing something

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are better included in middleware_manager as well, so that we have proper namespacing for the resources, what do you think?

Another option would be ManageIQ::Providers::Hawkular::WildFlyServer. Any of the two are fine by me.

end

say_with_time('Migrating middleware_server to middleware_server_eap') do
MiddlewareServer
.where("type = ? AND product ~* ?", 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServer', 'eap')
.update_all(:type => 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServerEap')
end
end

def down
say_with_time('Migrating middleware_server_wildfly to middleware_server') do
MiddlewareServer
.where(:type => 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServerWildfly')
.update_all(:type => 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServer')
end

say_with_time('Migrating middleware_server_eap to middleware_server') do
MiddlewareServer
.where(:type => 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServerEap')
.update_all(:type => 'ManageIQ::Providers::Hawkular::MiddlewareManager::MiddlewareServer')
end
end

end