Move Openstack refresher settings #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
force-pushed
the
move-openstack-refresher-settings
branch
from
2fbcc99
to
2ff0b63
Compare
|
Checked commit mansam@2ff0b63 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
mansam
changed the title
Fryguy
reviewed
Oct 20, 2017
|
|
||
| def up | ||
| say_with_time('Move Openstack provider refresher settings') do | ||
| SettingsChange.where(:key => '/ems/ems_openstack/refresh/inventory_object_refresh').update(:key => '/ems/ems_refresh/openstack/inventory_object_refresh') |
There was a problem hiding this comment.
Prefer update_all over update as it will go direct to the DB instead of instantiating one-by-one.
Doesn't matter since you search for a single key. However, if the entirety of "/ems/ems_openstack/refresh" is changing you can also do:
SettingsChange.where("key LIKE ?", "/ems/ems_openstack/refresh/%"').each do |sc|
sc.update_attributes!(:key => sc.key.sub("/ems/ems_openstack/refresh/", "/ems/ems_refresh/openstack")
endThere was a problem hiding this comment.
Cool. The changes aren't all exactly 1-1 so I'm going to stick with the explicit calls, if that's alright with you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.