-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user_id,group_id,tenant_id to EventStream. #94
Conversation
eaf0646
to
28ed745
Compare
Checked commit lfu@28ed745 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
@miq-bot add_label enhancement |
👍 |
Do wish we did not have user_id in event - and wish it could be derived in the receiver (since an event from vmware would not actually have a user_id on it) But, this seems like a good way to make sure that a user is passed through the system. (rather than the bogus 👍 |
My concern here is that storing user_ids typically has complications for the global region and we usually store the user "name" in those cases. However, I don't think event_streams are replicated, so maybe it doesn't matter cc @gtanzillo @gmcculloug Thoughts? |
@Fryguy In my understanding |
The problem is that "jsmith" in region 1 will have an id of 1_000_000_000_001, but in region 99 his id will be 99_000_000_000_001. If we replicate region 1 into region 99, then his name exists twice, and then you might need to merge his events from both regions. If you link by id only, then it can only see his events from a particular region, while if you link by userid, then you can see all of them. Since we do replicate events (they're not in the default_replication_exclude_tables.yml), I want @gtanzillo and @gmcculloug to approve first before merge. |
I'm good with this. Discussing with @gmcculloug, automate needs to reference the actual user of the event and not necessarily the user with the same name in the global region. Also, |
@Fryguy Please review/merge. |
Add user_id,group_id,tenant_id to EventStream.
User wants to get the event initiator from MiqEvent and uses it in automate code.
Blocks ManageIQ/manageiq#16179.
https://bugzilla.redhat.com/show_bug.cgi?id=1487749
cc @kbrock @Fryguy @mkanoor