Switch to GitHub Actions #13
Conversation
|
Is this ready to go? |
I am review them one-by-one which is why I WIP'd them...I've found I need manual changes in most of them (even if they go green). |
|
This is ready to go. |
|
Checked commits Fryguy/manageiq-ssh-util@1e5aade~...a9ae525 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint **
|
| @@ -1,6 +1,7 @@ | |||
| require 'net/ssh' | |||
| require 'net/sftp' | |||
| require 'tempfile' | |||
| require 'active_support' | |||
There was a problem hiding this comment.
I'm curious when/why this became a requirement, but rails/rails#43889 suggests that it's necessary.
There was a problem hiding this comment.
That's the one. It's also documented in the Rails docs that now you have to do require "active_support" first before you do any "partial" usage of "active_support". In this particular case, it happens to work anyway, but I want to future-proof the code in case they change something in the future.
### Removed - BREAKING: Drop support for Ruby 2.5 [#21] ### Changed - Bump net-ssh for OpenSSL 3.0 support [#21] - Update paambaati/codeclimate-action action to v6 [#22] - Add renovate.json [#15] - Update codeclimate channel to the latest in manageiq-style [#19] - Test with ruby 3.1 and 3.0 [#18] - Update actions/checkout version to v4 [#17] - Update GitHub Actions versions [#16] - Add timeout-minutes to setup-ruby job [#14] - Switch to GitHub Actions, Handle newer version of activesupport [#13] - Add .whitesource configuration file [#12] - Update manageiq-style [#10] - Add badges to readme [#9] - Remove codeclimate-test-reporter [#8] - Switch to manageiq-style [#7]
https://github.com/Fryguy/manageiq-ssh-util/actions?query=branch%3Agithub_actions for CI status.