Check basic toolbar buttons for rbac feature existence

[miq-bot]

Since ManageIQ/manageiq#10942 (in euwe), a toolbar button needs a corresponingly named rbac feature to exist, so that it would actually show.

Previously there was no such limitation.

Thus, we should ideally go through all the toolbar buttons which don't explicitly set a class, and check that a feature for these actually exists.

@PanSpagetka would you take care of that please?
Cc: @romanblanco

---

This issue was moved to this repository from ManageIQ/manageiq#11872, originally opened by @himdel

[himdel]

This is still alive, details in ManageIQ/manageiq#11872 (comment), but this is the list of toolbar button identifiers for which a feature doesn't exist and which aren't using ButtonWithoutRbac as their klass or inheriting from it:

• automation_manager_delete - inventory_group_center.rb
• automation_manager_edit - inventory_group_center.rb
• automation_manager_refresh - inventory_group_center.rb
• container_build_scan - container_builds_center.rb container_build_center.rb
• generic_object_definition_create - generic_object_definition_center.rb
• image_reconfigure - x_template_cloud_center.rb template_clouds_center.rb
• image_right_size - x_template_cloud_center.rb template_clouds_center.rb
• instance_resume - vm_clouds_center.rb cloud/instance_operations_button_group_mixin.rb
• ldap_domain_add - ldap_region_center.rb
• ldap_domain_delete - ldap_domain_center.rb
• ldap_domain_edit - ldap_domain_center.rb
• ldap_region_add - ldap_regions_center.rb
• ldap_region_delete - ldap_region_center.rb ldap_regions_center.rb
• ldap_region_edit - ldap_region_center.rb ldap_regions_center.rb
• miq_request_approve - miq_request_center.rb
• miq_request_deny - miq_request_center.rb
• provider_foreman_configured_system_tag - x_foreman_configured_system_center.rb x_provider_foreman_foreman_configured_system_center.rb
• rbac_project_add - tenant_center.rb
• reload - saved_reports_center.rb
• schedule_run_now - miq_schedules_center.rb miq_schedule_center.rb

We should go through all of these to find out if they work and how, and fix those which don't.

[PanSpagetka]

• automation_manager_delete - inventory_group_center.rb (This toolbar is not used, need more investigation)
• automation_manager_edit - inventory_group_center.rb (This toolbar is not used, need more investigation)
• automation_manager_refresh - inventory_group_center.rb (This toolbar is not used, need more investigation)
• container_build_scan - container_builds_center.rb container_build_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• generic_object_definition_create - generic_object_definition_center.rb (OK)
• image_reconfigure - x_template_cloud_center.rb template_clouds_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• image_right_size - x_template_cloud_center.rb template_clouds_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• instance_resume - vm_clouds_center.rb cloud/instance_operations_button_group_mixin.rb Add Missing button features to miq_features.yaml manageiq#16027
• ldap_domain_add - ldap_region_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• ldap_domain_delete - ldap_domain_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• ldap_domain_edit - ldap_domain_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• ldap_region_add - ldap_regions_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• ldap_region_delete - ldap_region_center.rb ldap_regions_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• ldap_region_edit - ldap_region_center.rb ldap_regions_center.rb Add Missing button features to miq_features.yaml manageiq#16027
• miq_request_approve - miq_request_center.rb (uses miq_request_approval)
• miq_request_deny - miq_request_center.rb (uses miq_request_approval)
• provider_foreman_configured_system_tag - x_foreman_configured_system_center.rb x_provider_foreman_foreman_configured_system_center.rb (Change name of Foreman Tag Edit button #2268)
• rbac_project_add - tenant_center.rb (Uses tenant_add for RBAC as it should)
• reload - saved_reports_center.rb (overriding visible? in button class, no RBAC check at all)
• schedule_run_now - miq_schedules_center.rb (overriding visible? in button class, no RBAC check at all)

[romanblanco]

@himdel can this issue be closed now?

[himdel]

ManageIQ/manageiq#16027 is merged, closing :)