Add Missing button features to miq_features.yaml

[PanSpagetka]

Add features to miq_features.yaml

Screenshots:

Commit1:

Before:

After:

Commit2:

Before:

After:

Commit3:

No screenshot, you need paused instance.

Commit 4:

Before:

After:

Issue:

ManageIQ/manageiq-ui-classic#2208

Steps for Testing/QA [Optional]

Look at all modified screens, that button is there and nothing goes wrong.
For enabling LDAP you need to add :new_ldap: true into :product: in configuration.yaml

[PanSpagetka]

@miq-bot add_label wip

[romanblanco]

@miq-bot assign @romanblanco

[PanSpagetka]

@miq-bot remove_label wip

[PanSpagetka]

@romanblanco please review

[miq-bot]

Checked commits PanSpagetka/manageiq@ef72767~...d0c97b7 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

[romanblanco]

Steps to reproduce + review:

commit ef72767: Compute → Containers → Container Builds → [select a build in GTL]

• review: The Configuration button
  (container_build_scan) that should be enabled by the changes displays correctly 👍. I'm missing the PDF downolad button, that is visible on the screenshots, but this might be intentional

commit a16d9a5: Compute → Clouds → Instances → Images accordion → [select an image in GTL]

• review: Both image_reconfigure and image_right_size show up 👍

commit b449c4e: Compute → Clouds → Instances → [select a paused instance in GTL]

• review: instance_resume appears 👍 , but has missing icon (fixed in Added missing icon for 'instance_resume' feature manageiq-ui-classic#2821):
  

commit d0c97b7:

1. enable LDAP:

   • Configuration → Settings accordion → Advanced tab → [update the YAML configuration by adding :new_ldap under :product]

      :product:
       :new_ldap: true

2. add a LdapRegion, easiest way is probably by Rails console:

   [6] pry(main)> a = LdapRegion.new(:name => "Spaghetti")
   => #<LdapRegion:0x00565155a08c08 id: nil, name: "Spaghetti", description: nil, zone_id: nil, created_at: nil, updated_at: nil>
   [7] pry(main)> a.save!
      (0.3ms)  BEGIN
     LdapRegion Exists (0.5ms)  SELECT  1 AS one FROM "ldap_regions" WHERE "ldap_regions"."name" = $1 LIMIT $2  [["name", "Spaghetti"], ["LIMIT", 1]]
     SQL (3.8ms)  INSERT INTO "ldap_regions" ("name", "created_at", "updated_at") VALUES ($1, $2, $3) RETURNING "id"  [["name", "Spaghetti"], ["created_at", "2017-11-22 13:20:50.221899"], ["updated_at", "2017-11-22 13:20:50.221899"]]
      (1.2ms)  COMMIT
   => true

3. restart Rails server

4. Configuration → Settings accordion → [select LDAP in tree in Settings accordion]
   - review: works 👍

[romanblanco]

Tested changes, looks good to me 👍

[romanblanco]

@miq-bot assign @himdel

[himdel]

@miq-bot assign martinpovolny

(LGTM, but I can't merge here)

[martinpovolny]

Gaprindashvili?

[martinpovolny]

@PanSpagetka : don't we need any of the new features in the miq_user_roles.yaml?

http://talk.manageiq.org/t/product-features-and-roles/2855

[PanSpagetka]

@martinpovolny I don't think so, I didn't create any new category, just add to existing ones. So it should be included in existing ones.

And yes, I think this should be backported to G.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 944d7a779d891aceba7612ab347c4449bb4aa696
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Tue Nov 28 15:40:41 2017 +0100

    Merge pull request #16027 from PanSpagetka/modify-miq-features-for-buttons
    
    Add Missing button features to miq_features.yaml
    (cherry picked from commit 88900836e9767ab47c3609a48dd7fb965cc3a17c)