Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing icon for 'instance_resume' feature #2821

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Added missing icon for 'instance_resume' feature #2821

merged 1 commit into from
Nov 29, 2017

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Nov 24, 2017 •
edited
Loading

Before:
screenshot from 2017-11-24 15-57-45

After:
screenshot from 2017-11-24 16-05-56

I'm not sure if this is correct icon, but it's better than before ¯\_(ツ)_/¯.
@epwinchell please check if this is OK or if there is better option.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1517804

Steps for Testing/QA

Compute → Clouds → Instances → [select paused instance in GTL]

@romanblanco romanblanco mentioned this pull request Nov 24, 2017
Merged
@miq-bot
Copy link
Member

miq-bot commented Nov 24, 2017

Checked commit romanblanco@a38f8dd with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@romanblanco
Copy link
Member Author

@miq-bot assign @epwinchell

@mzazrivec
Copy link
Contributor

@romanblanco Is this gaprindashvili/yes ?

The icon looks fine to me, though I'll let Eric to chime in.

@romanblanco
Copy link
Member Author

romanblanco commented Nov 27, 2017 •
edited
Loading

@romanblanco Is this gaprindashvili/yes ?

@mzazrivec Yes.

@romanblanco
Copy link
Member Author

@miq-bot add_label gaprindashvili/yes

@epwinchell
Copy link
Contributor

@romanblanco Looks fine

@epwinchell
Copy link
Contributor

@miq-bot assign @himdel

@miq-bot miq-bot assigned himdel and unassigned epwinchell Nov 29, 2017
@epwinchell
Copy link
Contributor

@miq-bot add_label graphics

@mzazrivec mzazrivec added this to the Sprint 75 Ending Dec 11, 2017 milestone Nov 29, 2017
@mzazrivec mzazrivec merged commit 48965d5 into ManageIQ:master Nov 29, 2017
@mzazrivec mzazrivec assigned mzazrivec and unassigned himdel Nov 29, 2017
@romanblanco romanblanco deleted the correct_resume_icon branch November 29, 2017 14:28
simaishi pushed a commit that referenced this pull request Nov 29, 2017
@mzazrivec @simaishi
Merge pull request #2821 from romanblanco/correct_resume_icon
2df7ec9 
Added missing icon for 'instance_resume' feature
(cherry picked from commit 48965d5)

https://bugzilla.redhat.com/show_bug.cgi?id=1518863
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 2df7ec9381701ac60ce51f7ce057ed0e73994bae
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Wed Nov 29 15:28:35 2017 +0100

    Merge pull request #2821 from romanblanco/correct_resume_icon
    
    Added missing icon for 'instance_resume' feature
    (cherry picked from commit 48965d5ccc1ca3c1a2978a171accebf302e194c0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1518863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/infrastructure gaprindashvili/backported graphics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@romanblanco @miq-bot @mzazrivec @epwinchell @simaishi @himdel