Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PatternFly to v3.23.1 #1019

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Update PatternFly to v3.23.1 #1019

merged 1 commit into from
Apr 13, 2017

Conversation

skateman
Copy link
Member

@NickLaMuro here you go 😉

@miq-bot
Copy link
Member

miq-bot commented Apr 12, 2017

Checked commit skateman@14a22a8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks good. ⭐

@himdel
Copy link
Contributor

himdel commented Apr 13, 2017

Adding fine/yes because this also fixes the info icon issue.

@himdel himdel added fine/yes and removed fine/no labels Apr 13, 2017
@himdel himdel added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 13, 2017
@himdel himdel merged commit c449eb7 into ManageIQ:master Apr 13, 2017
@himdel
Copy link
Contributor

himdel commented Apr 13, 2017

Tested in the UI, doesn't seem to break anything (patch release, yay! :)), and fixes the info icon 👍

@himdel
Copy link
Contributor

himdel commented Apr 13, 2017

@simaishi When backporting a fine, the bower.json bit needs to go in both manageiq and manageiq-ui-classic again, thanks! :)

@himdel himdel mentioned this pull request Apr 13, 2017
Merged
@skateman skateman deleted the patternfly-3.23.1 branch April 13, 2017 14:45
simaishi pushed a commit that referenced this pull request Apr 13, 2017
@himdel @simaishi
Merge pull request #1019 from skateman/patternfly-3.23.1
79f8c67 
Update PatternFly to v3.23.1
(cherry picked from commit c449eb7)
@simaishi
Copy link
Contributor

Fine backport details:

$ git log -1
commit 79f8c676da8fa1786f0c39b406f2b3cfa1725695
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Apr 13 13:57:11 2017 +0000

    Merge pull request #1019 from skateman/patternfly-3.23.1
    
    Update PatternFly to v3.23.1
    (cherry picked from commit c449eb7ae07cca0c232da4fd65e43e30c8c0c8d8)

@simaishi
Copy link
Contributor

Also backported to manageiq repo:

$ git log -1
commit 6a7bef971676ad74c2c51a7d55035ae5c8171bfe
Author: Martin Hradil <himdel@seznam.cz>
Date:   Thu Apr 13 13:57:11 2017 +0000

    Merge pull request #1019 from skateman/patternfly-3.23.1
    
    Update PatternFly to v3.23.1
    (cherry picked from commit c449eb7ae07cca0c232da4fd65e43e30c8c0c8d8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@himdel himdel

Labels
dependencies fine/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @himdel @simaishi @dclarizio