Fix missing tree view in Datastore Clusters accordion #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1404259 Fix missing tree view in Datastore Clusters accordion in Compute -> Infrastructure -> Datastores -> Datastore Clusters by removing Advanced searchbox which should not be available when reaching Datastore Clusters accordion. Advanced search should only be available on Datastores accordion that displays filters in tree.
hstastna
force-pushed
the
Filter_Datastore_Clusters_missing_tree_view
branch
from
94cef7d
to
6c722bc
Compare
|
Checked commit hstastna@6c722bc with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
Euwe backport (to manageiq repo) details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing https://bugzilla.redhat.com/show_bug.cgi?id=1404259
Fix missing tree view in Datastore Clusters accordion in
Compute -> Infrastructure -> Datastores -> Datastore Clusters
by removing Advanced searchbox which should not be available
when reaching Datastore Clusters accordion. Advanced search
should only be available on Datastores accordion that displays
filters in tree.
This bug is fixed by adding a condition to
display_adv_searchboxmethodin storage controller which has a role to hide/show advanced searchbox.
Originally it was designed to show advanced searchbox all the time in
Compute -> Infrastructure -> Datastores .
This bug was also mentioned in ManageIQ/manageiq#13140
Before:
After:
