Changed if condition to rely on back-end method. #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I just found out that this exists. That should handle this use case. I'll open a separate PR to change the existing provider code to use this method as well but that won't block you. |
|
Made ManageIQ/manageiq#15094 to change the Provider logic on the backend. |
h-kataria
force-pushed
the
ansible_role_enabled_check_fix
branch
from
54c1cf1
to
1ff6dd7
Compare
Changed check to call back-end method "MiqRegion#role_active?" to decide whether button should be enabled/disabled https://bugzilla.redhat.com/show_bug.cgi?id=1450290
h-kataria
force-pushed
the
ansible_role_enabled_check_fix
branch
from
1ff6dd7
to
c4bd99d
Compare
h-kataria
changed the title
|
Checked commit h-kataria@c4bd99d with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
simaishi
pushed a commit
that referenced
this pull request
May 15, 2017
Changed if condition to rely on back-end method. (cherry picked from commit ce30797) https://bugzilla.redhat.com/show_bug.cgi?id=1451121
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed check to call back-end method "MiqRegion#role_active?" to decide whether button should be enabled/disabled
https://bugzilla.redhat.com/show_bug.cgi?id=1450290
@carbonin changed code to call back-end method, will replace this call with new method when that's ready