Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove datawarehouse views #1502

Merged

Conversation

moolitayer
Copy link

We are moving away from using the datawarehouse manager as an external provider to integrating it in container providers. Removing all screens added in ManageIQ/manageiq#12205

Needed for ManageIQ/manageiq#15295

@martinpovolny
Copy link
Member

Travis failure seems related.

@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2017

This pull request is not mergeable. Please rebase and repush.

@martinpovolny
Copy link
Member

@moolitayer : what is the status of this PR? Do you need any assistance? Thx!

@martinpovolny martinpovolny changed the title Remove datawarehouse views [WIP] Remove datawarehouse views Oct 10, 2017
@moolitayer
Copy link
Author

@martinpovolny I will get back to working on this as soon as I can

@martinpovolny
Copy link
Member

@moolitayer : ping?

@moolitayer
Copy link
Author

@martinpovolny please review. Should I remove the locale stuff as well?

@moolitayer moolitayer changed the title [WIP] Remove datawarehouse views Remove datawarehouse views Dec 24, 2017
@moolitayer
Copy link
Author

@miq-bot add_label gaprindashvili/no

@moolitayer
Copy link
Author

@miq-bot remove_label wip

@moolitayer moolitayer force-pushed the remove_datawarehouse_views branch 2 times, most recently from 4480f1a to b0731a4 Compare December 24, 2017 15:49
@moolitayer
Copy link
Author

@martinpovolny I'll do another run on the original PR tomorrow to make sure I didn't forget stuff
(I just noticed that one touched a lot more files)

@moolitayer
Copy link
Author

@martinpovolny ping

@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2018

This pull request is not mergeable. Please rebase and repush.

@martinpovolny
Copy link
Member

Please, rebase and ping me. Thx!

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2018

Checked commit moolitayer@b35b48b with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 0 offenses detected
Everything looks fine. 🏆

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2018

This pull request is not mergeable. Please rebase and repush.

@moolitayer
Copy link
Author

Rebased, fixed tests & checked ManageIQ/manageiq#12205 to make sure nothing is missing.
Ran UI sanity check (Edit provider)

Ping @martinpovolny

@martinpovolny martinpovolny merged commit 776b025 into ManageIQ:master Jan 10, 2018
@martinpovolny martinpovolny added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants