Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix valid_tenant check in ops. #203

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Fix valid_tenant check in ops. #203

merged 1 commit into from
Jan 20, 2017

Conversation

martinpovolny
Copy link
Member

Closes #202

Introduced in #151

To go to euwe togetgher with #151

Ping @mzazrivec, @lpichler, @abellotti : please, review

lpichler
lpichler approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@lpichler lpichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 minor thing, I am just avoiding negatives if possible :)
Rbac.filtered(Tenant.in_my_region.where(:id => tenant_id)).present?

@mzazrivec mzazrivec self-assigned this Jan 20, 2017
@martinpovolny
Copy link
Member Author

@lpichler : fixed, thx!

@miq-bot
Copy link
Member

miq-bot commented Jan 20, 2017

Checked commit martinpovolny@4dc143c with ruby 2.2.6, rubocop 0.46.0, and haml-lint 0.19.0
1 file checked, 0 offenses detected
Everything looks good. 👍

@mzazrivec mzazrivec added this to the Sprint 53 Ending Jan 30, 2017 milestone Jan 20, 2017
@mzazrivec mzazrivec merged commit 4d38cb9 into ManageIQ:master Jan 20, 2017
@martinpovolny martinpovolny mentioned this pull request Jan 20, 2017
Merged
@simaishi
Copy link
Contributor

Euwe backport (to manageiq repo) details:

$ git log -1
commit c43b90c82a71250aeed15b9a50cf0cd2456128b3
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri Jan 20 13:49:05 2017 +0100

    Merge pull request #203 from martinpovolny/fix_valid_tenant
    
    Fix valid_tenant check in ops.
    (cherry picked from commit 4d38cb9c147dcce7048ba3920a3e3be86482fdb7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1415217

@martinpovolny martinpovolny deleted the fix_valid_tenant branch March 8, 2017 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpichler lpichler lpichler approved these changes

Assignees

@mzazrivec mzazrivec

Labels
bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinpovolny @miq-bot @simaishi @lpichler @mzazrivec