Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use quota_display in Container Project summary screen #2090

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

zakiva
Copy link
Contributor

@zakiva zakiva commented Sep 4, 2017

Depends on: ManageIQ/manageiq#15639

Use the new quota_*_display virtual columns where the float values are converted to strings with rounding for integers.

Before:
quotabefore

After:
quotaadter

@zakiva
Copy link
Contributor Author

zakiva commented Sep 4, 2017

@simon3z @zeari

@zakiva
Copy link
Contributor Author

zakiva commented Sep 4, 2017

@miq-bot add_label compute/containers

@miq-bot
Copy link
Member

miq-bot commented Sep 4, 2017

Checked commit zakiva@3c123e8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@dclarizio
Copy link

@zakiva can you add some before/after screen shots? Thx, Dan

@zakiva
Copy link
Contributor Author

zakiva commented Oct 1, 2017

@zakiva can you add some before/after screen shots? Thx, Dan

Added in the description above.

@zakiva
Copy link
Contributor Author

zakiva commented Oct 15, 2017

@dclarizio Core PR was merged, this should be ready now.

@mzazrivec mzazrivec added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 16, 2017
@mzazrivec mzazrivec merged commit b71093e into ManageIQ:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants