Add timeline to physical server

[lucashsilva]

This PR consists in adding the monitoring button group with timelines button to the physical server page and making the timeline page available when this button is clicked.

Physical server page with monitoring button group

Disabled when there are no events for the physical server

Enabled when there are events for the physical server

Timeline page before filtering

Timeline page after filtering

This PR depends on core PR 16084.

[lucashsilva]

@miq-bot add_label enhancement

[AndreyMenezes]

@juliancheal @AparnaKarve

[juliancheal]

Looks like just a couple of tests need passing.

[lucashsilva]

@juliancheal this PR depends on core PR 16084, and that's why the tests are failing. I saw your restarted its build, which had failed, and everything looks fine now.

[juliancheal]

@lucashsilva ah thanks, I'd missed that in the first comment that it relied on another PR, thanks!

[lucashsilva]

@juliancheal @AparnaKarve everything looks fine now :)

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[lucashsilva]

@agrare could you please take a look at this?

[agrare]

ping @AparnaKarve

[AparnaKarve]

@lucashsilva Since you have defined the mixin Mixins::MoreShowActions at the top, could you simply call the method show_timeline instead of writing this block?

[lucashsilva]

@AparnaKarve I figured out I didn't use anything from this mixin and that the model I followed didn't either. Sorry for that. I also tried to do what you said but the user is not redirected to the timelines page and nothing is shown. If you look at this, you'll see a similar code, which was the way I found to redirect the user to the timelines page. How should I proceed?

Is it necessary to execute the lines 51 to 57 if the user will be redirected to a new page?
I could get the button to work and redirect correctly with lines 52 and 58 only and without the mixin.

[AparnaKarve]

@lucashsilva I think it would be better to use the mixin.
The eventual goal would be to make use of the mixin in the entire app and remove duplication.

Can you give this a try -

if params[:pressed] == "physical_server_timeline"
  @record = find_record_with_rbac(ManageIQ::Providers::PhysicalInfraManager::PhysicalServer, params[:id])
  show_timeline
  javascript_redirect :action => 'show', :id => @record.id, :display => 'timeline'
end

[lucashsilva]

@AparnaKarve I tried it and it works. I already pushed the change.

[AparnaKarve]

@lucashsilva Overall the code looks good.
Per my above comment, if you could leverage the mixin method, that would be great.

[miq-bot]

Checked commits lucashsilva/manageiq-ui-classic@287a65b~...dabe446 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
5 files checked, 0 offenses detected
Everything looks fine. 🍪

[agrare]

@AparnaKarve can you give it another look? Thanks!

[chessbyte]

Reviewed by @Fryguy and @blomquisg -- merging.