Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding section for Physical Servers in default filters configuration screen #2338

Merged

Conversation

douglasgabriel
Copy link
Member

@douglasgabriel douglasgabriel commented Oct 10, 2017

Depends on:

ManageIQ/manageiq#16158

This PR is able to:

  • Add in "My Settings" -> "Default Filters" the section "Physical Infrastructure" to configure filters for physical servers.

image

@douglasgabriel
Copy link
Member Author

@agrare

@miq-bot
Copy link
Member

miq-bot commented Oct 10, 2017

Checked commit douglasgabriel@34737b7 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@rodneyhbrown7
Copy link

@miq-bot assign @dclarizio

@douglasgabriel
Copy link
Member Author

@AndreyMenezes

@h-kataria
Copy link
Contributor

@douglasgabriel just want to point out that changes in this PR does not affect Physical Infrastructure Servers list view screen, those filters should already be visible in listnav without changes in this PR.

@dclarizio dclarizio merged commit 164e565 into ManageIQ:master Oct 20, 2017
@dclarizio dclarizio added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants