Fix failing menus_spec.rb

[mzazrivec]

No description provided.

[miq-bot]

Checked commit mzazrivec@fb4b801 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[himdel]

Fixes... on travis. (link)

  1) ReportController#menu_update set menus to default and sets correct title for custom reports
     Failure/Error:
           rptmenu[0].each do |r|
             next unless r.class == String && r == @sb[:grp_title]
       
             @custom_folder = copy_array(rptmenu[0]) if @custom_folder.nil?
             # Keeping My Company Reports folder on top of the menu tree only if user is on edit tab, else delete it from tree
             # only add custom folder if it has any reports
             rptmenu.push(rptmenu[0]) unless rptmenu[0][1][0][1].empty?
             rptmenu.delete_at(0)
           end

     
     NoMethodError:
       undefined method `each' for nil:NilClass
     # ./app/controllers/application_controller.rb:986:in `get_reports_menu'
     # ./app/controllers/application_controller.rb:896:in `populate_reports_menu'
     # ./app/controllers/report_controller/menus.rb:212:in `menu_update'
     # ./spec/controllers/miq_report_controller/menus_spec.rb:18:in `block (3 levels) in <top (required)>'

[himdel]

Introduced by ManageIQ/manageiq#16716.

[himdel]

@simaishi Looks like gaprindashvili travis is already failing https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/325255787#L2718.

This PR should fix it.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 5677457f8ad5b7d98be57ec65a32ea31fc964510
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Jan 5 14:30:05 2018 +0100

    Merge pull request #3171 from mzazrivec/fix_failing_menus_spec
    
    Fix failing menus_spec.rb
    (cherry picked from commit a12b1c7e5317e5016c6aa6c67b9a3216936457c3)

[simaishi]

Fine backport details:

$ git log -1
commit 91c238195edbde88d539c0c3fe9b111dde16e22b
Author: Martin Hradil <himdel@seznam.cz>
Date:   Fri Jan 5 14:30:05 2018 +0100

    Merge pull request #3171 from mzazrivec/fix_failing_menus_spec
    
    Fix failing menus_spec.rb
    (cherry picked from commit a12b1c7e5317e5016c6aa6c67b9a3216936457c3)