Factories should be referenced by symbol

[bdunne]

@himdel Please review. Found when looking into ManageIQ/manageiq#16768 (comment)

[himdel]

@bdunne Ah, LGTM, but if the idea is to always pass a symbol as a name of the factory, there's also..

spec/controllers/ems_physical_infra_controller_spec.rb
99:        ems = FactoryGirl.create("ems_physical_infra")

spec/controllers/ems_infra_controller_spec.rb
359:        ems = FactoryGirl.create("ems_vmware")

[bdunne]

Okay @himdel I think I've got all of them now. I also opened some other PR's to fix other issues in the list.

[miq-bot]

Checked commit bdunne@3a23678 with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 🏆

[himdel]

LGTM, thanks! :)

I'll go through the other PRs later..