[FINE] labels and tags mapping support for Azure #3801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinpovolny please review |
|
Checked commit AlexanderZagaynov@37092aa with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
(specs should pass once #3811 is merged) |
|
Restarted travis. |
|
@martinpovolny @himdel - Can you approve this? Code freeze for 5.8.4 is today. |
|
@AlexanderZagaynov You mean the 'master' PR can to go Fine branch as is?? If so, please close this PR and add |
|
closing in favour of direct cherry-picking by @simaishi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Fine's version of the #3697
Should be merged after ManageIQ/manageiq-providers-azure#242
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1493041