Add Redfish provider creation dialog #3912

tadeboro · 2018-05-08T09:42:29Z

This pull requests contains UI modifications that are needed in order to be able to create new Redfish provider from the MIQ web UI.

/cc @gberginc @gtanzillo @Fryguy

gberginc · 2018-05-09T04:35:56Z

Marking WIP as it depends on the provider actually being migrated to ManageIQ.

@miq-bot add_label wip

tadeboro · 2018-05-15T20:23:18Z

@miq-bot remove_label wip

tadeboro · 2018-05-15T20:23:34Z

Related bugzilla entry: https://bugzilla.redhat.com/show_bug.cgi?id=1574808

mzazrivec · 2018-05-16T09:16:21Z

Is there any backend / provider PR that this PR depends on?

tadeboro · 2018-05-16T09:46:30Z

@mzazrivec Sorry, forgot to add this info. Relevant core pull request is ManageIQ/manageiq#17392, so this will need to wait for that pull request to get merged.

@miq-bot add_label wip

gberginc

Please check my comment regarding the security protocols.

gberginc · 2018-05-18T07:45:19Z

app/views/layouts/angular-bootstrap/_endpoints_angular.html.haml

@@ -33,7 +34,7 @@
 "selectpicker-for-select-tag" => "",
 "prefix" => prefix.to_s,
 "reset-validation-status" => "#{prefix}_auth_status")
- .col-md-8{"ng-if" => "emsCommonModel.emstype == 'nuage_network'"}
+ .col-md-8{"ng-if" => "emsCommonModel.emstype == 'nuage_network' || emsCommonModel.emstype == 'redfish_ph_infra'"}


I would separate this now. Even if the set of security options is compatible for Nuage and Redfish, the latter does not support AMQP for the eventing (the next row checks whether the security protocols are displayed for AMQP tab or for the main tab; or at least, this is my understanding).

Thus, I suggest we create a new block specifically for the Redfish provider. Once events are going to be supported, we will add the security options for that as well (if necessary).

This was a remnant from "I just want something to show on UI" times that I forgot to clean up properly. I will fix this by creating new Redfish-only block that will use dedicated security protocol list.

gberginc · 2018-05-18T07:46:53Z

app/views/layouts/angular/_multi_auth_credentials.html.haml

@@ -491,6 +491,7 @@
 %div{"ng-if" => "#{ng_model}.emstype == 'gce' || " + |
 "#{ng_model}.emstype == 'scvmm' || " + |
 "#{ng_model}.emstype == 'lenovo_ph_infra' || " + |
+ "#{ng_model}.emstype == 'redfish_ph_infra' || " + |


I suppose this is correct place to put it?

It is correct in the sense that the following code hides all the tabs that we do not need. I considered adding a separate block for Redfish provider, but I decided against it when I saw that other providers are already reusing the configuration block. Besides, we can always create a new block if/when we actually need to made some customizations.

gberginc

Thanks @tadeboro.

Please remove wip and assign this PR to @mzazrivec if dependencies are now satisfied.

tadeboro · 2018-05-18T09:35:36Z

@miq-bot remove_label wip
@miq-bot assign @mzazrivec

mzazrivec · 2018-05-18T09:44:04Z

@epwinchell Could you please look at the graphics part of this PR? Thanks.

tadeboro · 2018-05-23T05:53:57Z

Some screenshots of UI changes in action:

martinpovolny · 2018-05-24T08:24:47Z

ping @terezanovotna

terezanovotna · 2018-05-24T08:43:53Z

waiting to get an MIQ environment where I can see these edits. Currently getting server error.

epwinchell · 2018-05-24T13:21:42Z

@tadeboro Please use a symlink for "vendor-redfish_ph_infra.svg" that points to "vendor-redfish." Thanks.

cc \ @skateman

tadeboro · 2018-05-24T17:54:46Z

@epwinchell I never noticed all those symlinks. I replaced the app/assets/images/svg/vendor-redfish_ph_infra.svg with symlink to app/assets/images/svg/vendor-redfish.svg as instructed.

epwinchell · 2018-05-25T00:19:09Z

@tadeboro Thank you

epwinchell · 2018-05-25T00:19:43Z

@miq-bot add_reviewer @epwinchell

terezanovotna · 2018-05-25T08:15:56Z

The dialog is being consistent with the current provider form, so @miq-bot remove_labels ux/review
@miq-bot add_labels ux/approved

(as a side note, the provider form itself has some issues, but that's a different topic)

terezanovotna · 2018-05-25T08:39:23Z

@miq-bot remove_label ux/review

himdel · 2018-05-28T11:44:03Z

LGTM, do we have any servers to test this with?

tadeboro · 2018-05-28T12:55:16Z

@himdel Any server that supports Redfish will do. But since those are not the easiest things to come by, I will prepare a sanitized recording of a live server that can be replayed by the mock server. I will post the relevant links here as soon as I have something ready.

himdel · 2018-05-28T13:00:18Z

Perfect, thanks @tadeboro :)

tadeboro · 2018-05-30T18:38:22Z

As promised, I prepared a static recording of the Redfsh-capable system and the mock server that is capable of replaying those responses. All of this is available in redfish-recordings repo. Repository also contains short instructions on how to get the server running.

This server has enough functionality implemented to be able to serve as a substitute for the real thing when developing Redfish provider for MIQ. At the moment, authorization support is only partialy implemented in mock server (any username/password is accepted), so credentials entered in new provider form can be arbitrary.

miq-bot · 2018-06-04T17:13:54Z

This pull request is not mergeable. Please rebase and repush.

This commit introduces minimal changes that are needed in order to be able to add Redfish provider to ManageIQ.

miq-bot · 2018-06-05T15:14:58Z

Checked commit xlab-si@b3cbf19 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 1 offense detected

**

💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

mzazrivec · 2018-06-06T10:24:01Z

The provider creation dialog seems to be working all right.

I noticed few other things though:

Missing display name for the new physical server. I created Add display name for Physical Server (Redfish) manageiq#17532 for this.
With the mock server & data provided, I'm getting the following error when navigating to physical server summary screen:

 Started GET "/physical_server/show/136"
...
FATAL -- : Error caught: [ActionView::Template::Error] undefined method `disk_capacity' for nil:NilClass
manageiq-ui-classic/app/helpers/physical_server_helper/textual_summary.rb:96:in `textual_capacity'

Provider topology isn't working as expected: the icons seem to be missing, the graph wouldn't show object names.

Given the title of this PR says "provider creation dialog" I can merge this PR as long as the other issues will be fixed in later PRs. Is that OK with you @tadeboro ?

tadeboro · 2018-06-06T10:35:32Z

Thanks @mzazrivec for your comments and help with display name.

The error that you are seeing when navigating to server summary page: this is a know "bug" and is caused by the missing inventory. This will correct itself once we add hardware collection to the inventory refresh to the Redfish provider.

As for the topology, I notice that icons do not show up at first, but if I interact a bit with the UI, they do eventually show.

That being said, I would be overwhelmed it this PR could be merged.

miq-bot added the graphics label May 8, 2018

tadeboro force-pushed the redfish branch from 1adf6ae to 0fe6be2 Compare May 8, 2018 11:17

miq-bot changed the title ~~Add Redfish provider creation dialog~~ [WIP] Add Redfish provider creation dialog May 9, 2018

miq-bot added the wip label May 9, 2018

tadeboro force-pushed the redfish branch from 0fe6be2 to 8bead28 Compare May 15, 2018 20:21

miq-bot changed the title ~~[WIP] Add Redfish provider creation dialog~~ Add Redfish provider creation dialog May 15, 2018

miq-bot removed the wip label May 15, 2018

miq-bot changed the title ~~Add Redfish provider creation dialog~~ [WIP] Add Redfish provider creation dialog May 16, 2018

miq-bot added the wip label May 16, 2018

tadeboro force-pushed the redfish branch from 8bead28 to ea6fd0f Compare May 18, 2018 07:30

gberginc suggested changes May 18, 2018

View reviewed changes

tadeboro force-pushed the redfish branch from ea6fd0f to 369a615 Compare May 18, 2018 09:11

gberginc approved these changes May 18, 2018

View reviewed changes

miq-bot changed the title ~~[WIP] Add Redfish provider creation dialog~~ Add Redfish provider creation dialog May 18, 2018

miq-bot removed the wip label May 18, 2018

miq-bot assigned mzazrivec May 18, 2018

martinpovolny added the ux/review label May 24, 2018

tadeboro force-pushed the redfish branch from 369a615 to 2c25aeb Compare May 24, 2018 17:50

miq-bot requested a review from epwinchell May 25, 2018 00:20

epwinchell approved these changes May 25, 2018

View reviewed changes

martinpovolny added the pending core label May 25, 2018

miq-bot added the ux/approved label May 25, 2018

miq-bot removed the ux/review label May 25, 2018

himdel removed the pending core label May 28, 2018

miq-bot added the unmergeable label Jun 4, 2018

tadeboro force-pushed the redfish branch from 2c25aeb to 3418f45 Compare June 4, 2018 18:15

miq-bot removed the unmergeable label Jun 4, 2018

tadeboro force-pushed the redfish branch 2 times, most recently from 4107bf7 to c138af1 Compare June 5, 2018 09:23

Add Redfish provider creation dialog

b3cbf19

This commit introduces minimal changes that are needed in order to be able to add Redfish provider to ManageIQ.

tadeboro force-pushed the redfish branch from c138af1 to b3cbf19 Compare June 5, 2018 15:13

mzazrivec added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 6, 2018

mzazrivec merged commit 112cdd5 into ManageIQ:master Jun 6, 2018

tadeboro deleted the redfish branch June 6, 2018 10:54

himdel mentioned this pull request Jun 7, 2018

Redfish - add mock provider setup instructions ManageIQ/guides#315

Merged

dclarizio added the enhancement label Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Redfish provider creation dialog #3912

Add Redfish provider creation dialog #3912

tadeboro commented May 8, 2018

gberginc commented May 9, 2018

tadeboro commented May 15, 2018

tadeboro commented May 15, 2018

mzazrivec commented May 16, 2018 •

edited

Loading

tadeboro commented May 16, 2018

gberginc left a comment

gberginc May 18, 2018

tadeboro May 18, 2018

gberginc May 18, 2018

tadeboro May 18, 2018

gberginc left a comment

tadeboro commented May 18, 2018

mzazrivec commented May 18, 2018

tadeboro commented May 23, 2018

martinpovolny commented May 24, 2018

terezanovotna commented May 24, 2018

epwinchell commented May 24, 2018

tadeboro commented May 24, 2018

epwinchell commented May 25, 2018

epwinchell commented May 25, 2018

terezanovotna commented May 25, 2018

terezanovotna commented May 25, 2018

himdel commented May 28, 2018

tadeboro commented May 28, 2018

himdel commented May 28, 2018

tadeboro commented May 30, 2018

miq-bot commented Jun 4, 2018

miq-bot commented Jun 5, 2018

mzazrivec commented Jun 6, 2018

tadeboro commented Jun 6, 2018

Add Redfish provider creation dialog #3912

Add Redfish provider creation dialog #3912

Conversation

tadeboro commented May 8, 2018

gberginc commented May 9, 2018

tadeboro commented May 15, 2018

tadeboro commented May 15, 2018

mzazrivec commented May 16, 2018 • edited Loading

tadeboro commented May 16, 2018

gberginc left a comment

Choose a reason for hiding this comment

gberginc May 18, 2018

Choose a reason for hiding this comment

tadeboro May 18, 2018

Choose a reason for hiding this comment

gberginc May 18, 2018

Choose a reason for hiding this comment

tadeboro May 18, 2018

Choose a reason for hiding this comment

gberginc left a comment

Choose a reason for hiding this comment

tadeboro commented May 18, 2018

mzazrivec commented May 18, 2018

tadeboro commented May 23, 2018

martinpovolny commented May 24, 2018

terezanovotna commented May 24, 2018

epwinchell commented May 24, 2018

tadeboro commented May 24, 2018

epwinchell commented May 25, 2018

epwinchell commented May 25, 2018

terezanovotna commented May 25, 2018

terezanovotna commented May 25, 2018

himdel commented May 28, 2018

tadeboro commented May 28, 2018

himdel commented May 28, 2018

tadeboro commented May 30, 2018

miq-bot commented Jun 4, 2018

miq-bot commented Jun 5, 2018

mzazrivec commented Jun 6, 2018

tadeboro commented Jun 6, 2018

mzazrivec commented May 16, 2018 •

edited

Loading