Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding toolbar buttons to suspend a provider #4012

Closed
wants to merge 6 commits into from

Conversation

romanblanco
Copy link
Member

@romanblanco
Copy link
Member Author

/cc @skateman @slemrmartin

@Fryguy
Copy link
Member

Fryguy commented Jun 12, 2018

I merged ManageIQ/manageiq#17500 ... not sure if that's the only pending core PR or not.

@slemrmartin
Copy link
Contributor

slemrmartin commented Jun 13, 2018

@Fryguy ManageIQ/manageiq#17452 is not necessary but before we solve the way we choose to suspend, this PR shouldn't be merged

@slemrmartin
Copy link
Contributor

@romanblanco please change operations from enable! / disable! to resume! / pause!
according to my PR ManageIQ/manageiq#17452
there: https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ems_common.rb#L576

@romanblanco romanblanco changed the title Adding toolbar buttons to suspend a provider [WIP] Adding toolbar buttons to suspend a provider Jul 2, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2018

Checked commits romanblanco/manageiq-ui-classic@c214b72~...81bc35e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
10 files checked, 12 offenses detected

app/helpers/application_helper/toolbar/ems_cloud_center.rb

app/helpers/application_helper/toolbar/ems_clouds_center.rb

app/helpers/application_helper/toolbar/ems_infra_center.rb

app/helpers/application_helper/toolbar/ems_infras_center.rb

app/helpers/application_helper/toolbar/ems_physical_infra_center.rb

app/helpers/application_helper/toolbar/ems_physical_infras_center.rb

@romanblanco
Copy link
Member Author

Closing this PR, as the rest has been finished by @skateman in #4269. Thanks!

@romanblanco romanblanco deleted the bz1455145 branch July 16, 2018 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants