Display number of containers on the top right quad of container prov #4015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwinchell
approved these changes
May 31, 2018
|
Checked commit skateman@9563c29 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quadicon for container provider introduced some inconsistency compared with other provider quads. The top-right quad displays an icon based on the data collection is suspended for the given provider or not. As we're extending this suspend feature to other providers and planning to use the bottom-right quad for displaying this info on each one, this would cause some redundancy for the container provider quadicons.
So I'm proposing to use the top-right quad for container providers more consistently with the other provider quads and display in it the number of containers for the given provider. Analogously to the infra provider displays the number of VMs in the same quad.
Before:
After:
@miq-bot add_label gaprindashvili/no, GTLs, compute/containers
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @romanblanco