Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Details for notification emails #4291

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jul 13, 2018

Part of ManageIQ/manageiq#17673

This allows extra details to be part of notification emails

@miq-bot
Copy link
Member

miq-bot commented Jul 13, 2018

Checked commit kbrock@d59288f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@mzazrivec
Copy link
Contributor

@kbrock Please remove the pending core label once the core PR is merged. Thanks!

@kbrock
Copy link
Member Author

kbrock commented Jul 23, 2018

@mzazrivec Since the hash will not include this key, this will be a no-op before core is merged.

Can we merge this here before there?

@mzazrivec mzazrivec self-assigned this Jul 24, 2018
@mzazrivec mzazrivec added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 24, 2018
@mzazrivec mzazrivec merged commit 18b0183 into ManageIQ:master Jul 24, 2018
@kbrock kbrock deleted the monitor_notifier branch July 24, 2018 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants