-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint url for azure #4304
Add endpoint url for azure #4304
Conversation
/cc @djberg96 |
@AparnaKarve Looks good for now. However, I'm awaiting some clarification as to whether or not we'll need per-provider support for CA Certs. If so, we'll need to modify the UI to look similar to the RHV interface where they can paste in a cert into a text box. That probably means passing an Endpoint object instead of a URI object, but I'm not familiar with the RHV code right off. Update: we're not going to worry about CA certs for now. |
We are holding off on Azure Stack support for now, so let's keep this a WIP for now. |
This pull request is not mergeable. Please rebase and repush. |
@AparnaKarve Can you update/rebase this? Looks like we're interested in Azure stack again. :) |
18339d9
to
1610696
Compare
@djberg96 Rebase done. If possible, can you validate these changes again? |
1610696
to
b40ee3f
Compare
@agrare @bronaghs can someone please test this to see if this is ready to be merged now, this was marked as WIP as your comment #4304 (comment) |
@djberg96 can you test this? I don't have an azure environment to check it with. |
This pull request is not mergeable. Please rebase and repush. |
Last time I tried, it worked. The backend support was added in ManageIQ/manageiq-providers-azure#274. I can try again, though I think this PR needs to be rebased. |
@AparnaKarve can you rebase/repush |
Also remove unnecessary validation on spaces
b40ee3f
to
49ea685
Compare
Checked commits AparnaKarve/manageiq-ui-classic@b56624b~...49ea685 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
app/controllers/mixins/ems_common_angular.rb
|
Rebased the PR. The current spec failure in chargeback controller is unrelated to the changes here @djberg96 Please review/retest. |
@AparnaKarve @agrare Tested again locally. Yep, it works. :) |
@AparnaKarve can you please remove WIP label and from from title |
@h-kataria Done! |
Adds
Endpoint URL
for AzureDepends on ManageIQ/manageiq-providers-azure#274
https://bugzilla.redhat.com/show_bug.cgi?id=1594381