Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint url for azure #4304

Merged

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Jul 16, 2018

@miq-bot miq-bot added the wip label Jul 16, 2018
@AparnaKarve
Copy link
Contributor Author

/cc @djberg96

@djberg96
Copy link
Contributor

djberg96 commented Jul 19, 2018

@AparnaKarve Looks good for now.

However, I'm awaiting some clarification as to whether or not we'll need per-provider support for CA Certs. If so, we'll need to modify the UI to look similar to the RHV interface where they can paste in a cert into a text box. That probably means passing an Endpoint object instead of a URI object, but I'm not familiar with the RHV code right off.

Update: we're not going to worry about CA certs for now.

@bronaghs
Copy link

We are holding off on Azure Stack support for now, so let's keep this a WIP for now.

@miq-bot
Copy link
Member

miq-bot commented Aug 22, 2018

This pull request is not mergeable. Please rebase and repush.

@djberg96
Copy link
Contributor

djberg96 commented Nov 7, 2018

@AparnaKarve Can you update/rebase this? Looks like we're interested in Azure stack again. :)

@AparnaKarve AparnaKarve force-pushed the bz1594381_add_endpoint_url_for_azure branch from 18339d9 to 1610696 Compare November 8, 2018 23:49
@AparnaKarve
Copy link
Contributor Author

@djberg96 Rebase done.
I did a quick test to check if everything was working -- and everything is looking good.

If possible, can you validate these changes again?
Thanks!

@AparnaKarve AparnaKarve force-pushed the bz1594381_add_endpoint_url_for_azure branch from 1610696 to b40ee3f Compare November 9, 2018 00:05
@h-kataria
Copy link
Contributor

@agrare @bronaghs can someone please test this to see if this is ready to be merged now, this was marked as WIP as your comment #4304 (comment)

@agrare
Copy link
Member

agrare commented Feb 25, 2019

@djberg96 can you test this? I don't have an azure environment to check it with.

@miq-bot
Copy link
Member

miq-bot commented Feb 26, 2019

This pull request is not mergeable. Please rebase and repush.

@djberg96
Copy link
Contributor

Last time I tried, it worked. The backend support was added in ManageIQ/manageiq-providers-azure#274. I can try again, though I think this PR needs to be rebased.

@h-kataria
Copy link
Contributor

@AparnaKarve can you rebase/repush

@AparnaKarve AparnaKarve force-pushed the bz1594381_add_endpoint_url_for_azure branch from b40ee3f to 49ea685 Compare February 26, 2019 18:18
@miq-bot
Copy link
Member

miq-bot commented Feb 26, 2019

Checked commits AparnaKarve/manageiq-ui-classic@b56624b~...49ea685 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
7 files checked, 2 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

app/controllers/mixins/ems_common_angular.rb

@AparnaKarve
Copy link
Contributor Author

Rebased the PR.

The current spec failure in chargeback controller is unrelated to the changes here

@djberg96 Please review/retest.
Thank you!

@djberg96
Copy link
Contributor

@AparnaKarve @agrare Tested again locally. Yep, it works. :)

@h-kataria
Copy link
Contributor

@AparnaKarve can you please remove WIP label and from from title

@AparnaKarve AparnaKarve changed the title [WIP] Add endpoint url for azure Add endpoint url for azure Feb 27, 2019
@AparnaKarve
Copy link
Contributor Author

@h-kataria Done!

@miq-bot miq-bot removed the wip label Feb 27, 2019
@h-kataria h-kataria self-assigned this Feb 28, 2019
@h-kataria h-kataria added this to the Sprint 106 Ending Mar 4, 2019 milestone Feb 28, 2019
@h-kataria h-kataria merged commit f880387 into ManageIQ:master Feb 28, 2019
@AparnaKarve AparnaKarve deleted the bz1594381_add_endpoint_url_for_azure branch February 28, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants