Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nesting physical chassis #4594

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

tadeboro
Copy link
Contributor

@tadeboro tadeboro commented Sep 4, 2018

This change teaches topology creation process about chassis nesting
that can be produced by Redfish physical infrastructure provider.

Depends on #4593
Depends on ManageIQ/manageiq#17940

@miq-bot add_label wip

@miq-bot miq-bot changed the title Allow nesting physical chassis [WIP] Allow nesting physical chassis Sep 4, 2018
@miq-bot miq-bot added the wip label Sep 4, 2018
@tadeboro tadeboro force-pushed the allow-nesting-physical-chassis branch from d4321f9 to 2e5106f Compare September 6, 2018 08:05
@tadeboro
Copy link
Contributor Author

tadeboro commented Sep 6, 2018

Visual comparison of nested chassis hierarchies before and after this change:

no-hierarchy
hierarchy

@tadeboro tadeboro force-pushed the allow-nesting-physical-chassis branch from 2e5106f to 8b707cd Compare September 10, 2018 11:00
This commit teaches topology creation process about chassis nesting
that can be produced by Redfish physical infrastructure provider.
@tadeboro tadeboro force-pushed the allow-nesting-physical-chassis branch from 8b707cd to 2bd8d1c Compare September 11, 2018 08:19
@tadeboro
Copy link
Contributor Author

@miq-bot remove_label wip
@miq-bot add_reviewer @skateman

@miq-bot
Copy link
Member

miq-bot commented Sep 11, 2018

Checked commit xlab-si@2bd8d1c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@miq-bot miq-bot changed the title [WIP] Allow nesting physical chassis Allow nesting physical chassis Sep 11, 2018
@miq-bot miq-bot removed the wip label Sep 11, 2018
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@skateman
Copy link
Member

@miq-bot assign @mzazrivec

@mzazrivec mzazrivec added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 11, 2018
@mzazrivec mzazrivec merged commit d1e32e7 into ManageIQ:master Sep 11, 2018
@tadeboro tadeboro deleted the allow-nesting-physical-chassis branch September 11, 2018 14:05
@Fryguy Fryguy added this to the Sprint 95 Ending Sept 24, 2018 milestone Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants