Use existing Zone not 'default' for MiqServer.my_zone or in request

[ZitaNemeckova]

Fixing failures introduced by ManageIQ/manageiq#17987

@miq-bot add_label test

[miq-bot]

Checked commit ZitaNemeckova@20a81a3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 0 offenses detected
Everything looks fine. ⭐

[jrafanie]

I don't understand. Were we queueing things without a zone before this change?

[himdel]

The zone didn't exist, we would just use "default" before in the specs.. (without such a zone existing in the db)

[simaishi]

ManageIQ/manageiq#17987 is gaprindashvili/yes. Please add gaprindashvili/yes if this can be backported to Gaprindashvili as is.

[ZitaNemeckova]

@miq-bot add_label gaprindashvili/yes

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 52cd01460a218006516c973f5e8715b486f11de2
Author: Martin Hradil <himdel@seznam.cz>
Date:   Mon Sep 17 12:30:46 2018 +0000

    Merge pull request #4669 from ZitaNemeckova/fix_zone_related_failures
    
    Use existing Zone not 'default' for MiqServer.my_zone or in request
    
    (cherry picked from commit 248d49155a3be71abea1d407ba365a68ccccba2d)

[simaishi]

@ZitaNemeckova Travis is still failing in Gaprindashvili branch. Would you mind taking a look?

https://travis-ci.org/ManageIQ/manageiq-ui-classic/jobs/439823454

  1) VmOrTemplateController#vm_button_operation should continue to retire a vm
     Failure/Error:
       expect(assigns(:flash_array).first[:message]).to \
         include("Retirement initiated for 1 VM and Instance from the %{product} Database" % {:product => I18n.t('product.name')})
       expected "Error during 'retire_now': Validation failed: Zone is not included in the list" to include "Retirement initiated for 1 VM and Instance from the ManageIQ Database"
     # ./spec/controllers/application_controller/ci_processing_spec.rb:945:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:73:in `block (3 levels) in <top (required)>'
     # ./spec/manageiq/spec/support/evm_spec_helper.rb:35:in `clear_caches'
     # ./spec/spec_helper.rb:73:in `block (2 levels) in <top (required)>'

  2) ServiceController#vm_button_operation should continue to retire a service and does not render flash message 'xxx does not apply xxx' 
     Failure/Error:
       expect(assigns(:flash_array).first[:message]).to \
         include("Retirement initiated for 1 Service from the %{product} Database" % {:product => I18n.t('product.name')})
       expected "Error during 'retire_now': Validation failed: Zone is not included in the list" to include "Retirement initiated for 1 Service from the ManageIQ Database"
     # ./spec/controllers/application_controller/ci_processing_spec.rb:877:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:73:in `block (3 levels) in <top (required)>'
     # ./spec/manageiq/spec/support/evm_spec_helper.rb:35:in `clear_caches'
     # ./spec/spec_helper.rb:73:in `block (2 levels) in <top (required)>'

[ZitaNemeckova]

@simaishi Here's fix #4754 for Gaprindashvili.