Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for tenant product feature in tree node #4780

Merged

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 16, 2018

NOTE: original intention of this PR was not useful - so I removed it but we at least I added some specs.

@JPrause
Copy link
Member

JPrause commented Oct 24, 2018

@miq-bot add_label blocker

@JPrause
Copy link
Member

JPrause commented Oct 30, 2018

Since there hasn't been an update in two weeks, @lpichler can you provide a current update on this issue.

@lpichler
Copy link
Contributor Author

lpichler commented Nov 6, 2018

@JPrause this PR is not necesarry needed to solve BZ

@lpichler
Copy link
Contributor Author

lpichler commented Nov 6, 2018

@miq-bot remove_label blocker

@miq-bot miq-bot removed the blocker label Nov 6, 2018
@lpichler lpichler force-pushed the add_icon_for_tenant_feature_type branch from c7b1b03 to 7bb3f8b Compare April 9, 2019 10:40
@miq-bot
Copy link
Member

miq-bot commented Apr 9, 2019

Checked commit lpichler@7bb3f8b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@lpichler lpichler changed the title [WIP] Add icon for tenant product feature in tree node Add specs for tenant product feature in tree node Apr 9, 2019
@lpichler
Copy link
Contributor Author

lpichler commented Apr 9, 2019

@miq-bot assign @mzazrivec

@miq-bot miq-bot removed the wip label Apr 9, 2019
@mzazrivec mzazrivec added this to the Sprint 109 Ending Apr 15, 2019 milestone Apr 15, 2019
@mzazrivec mzazrivec merged commit 9e46d69 into ManageIQ:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants