Add create-react-context dependency to fix react-bootstrap-typeahead failure #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failure
react-bootstrap-typeahead 3.3.0 came out, and it requires create-react-context without depending on it, causing...
ERROR in ./node_modules/react-bootstrap-typeahead/lib/TypeaheadContext.js
Module not found: Error: Can't resolve 'create-react-context' in '/home/himdel/manageiq-ui-classic/node_modules/react-bootstrap-typeahead/lib'
resolve 'create-react-context' in '/home/himdel/manageiq-ui-classic/node_modules/react-bootstrap-typeahead/lib'
Parsed request is a module
using description file: /home/himdel/manageiq-ui-classic/node_modules/react-bootstrap-typeahead/package.json (relative path: ./lib)
Field 'browser' doesn't contain a valid alias configuration
@ ./node_modules/react-bootstrap-typeahead/lib/TypeaheadContext.js 12:49-80
@ ./node_modules/react-bootstrap-typeahead/lib/containers/menuItemContainer.js
@ ./node_modules/react-bootstrap-typeahead/lib/index.js
@ ./node_modules/patternfly-react/dist/esm/components/TypeAheadSelect/TypeAheadSelect.js
@ ./node_modules/patternfly-react/dist/esm/components/TypeAheadSelect/index.js
@ ./node_modules/patternfly-react/dist/esm/index.js
@ ./app/javascript/provider-dialogs/modal.js
@ ./app/javascript/packs/provider-dialogs-common.js
error Command failed with exit code 2.
during webpack.
But since react-bootstrap-typeahead is not a direct dependency (via patternfly-react), it's easier to fix the missing package than to override the version.
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/4e0c64116f081a3931a433fff8e583fd50e12090 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
(travis failure unrelated and known: #4921 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-bootstrap-typeahead 3.3.0 came out, and it requires create-react-context without depending on it, causing...
during webpack.
But since react-bootstrap-typeahead is not a direct dependency (via patternfly-react), it's easier to fix the missing package than to override the version.
Reported as ericgio/react-bootstrap-typeahead#411