Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade types/enzyme to fix Travis #5269

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Downgrade types/enzyme to fix Travis #5269

merged 1 commit into from
Feb 25, 2019

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Feb 25, 2019 •
edited
Loading

Broken by https://www.npmjs.com/package/@types/enzyme/v/3.9.0

Issue is described here:
microsoft/TypeScript#15972

Fixes:

ERROR in [at-loader] ./node_modules/@types/enzyme/index.d.ts:367:40 
    TS2370: A rest parameter must be of an array type.
ERROR in [at-loader] ./node_modules/@types/enzyme/index.d.ts:457:60 
    TS2370: A rest parameter must be of an array type.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[Webpacker] Compilation Failed

@miq-bot add_label build, hammer/no

@miq-bot miq-bot changed the title Downgrade types/enzyme to fix Travis [WIP] Downgrade types/enzyme to fix Travis Feb 25, 2019
@miq-bot miq-bot added the wip label Feb 25, 2019
@ZitaNemeckova
Copy link
Contributor Author

ZitaNemeckova commented Feb 25, 2019 •
edited
Loading

@miq-bot remove_label wip

@himdel what do you think?

@miq-bot

This comment has been minimized.

Sign in to view
@mzazrivec mzazrivec removed the wip label Feb 25, 2019
@himdel himdel changed the title [WIP] Downgrade types/enzyme to fix Travis Downgrade types/enzyme to fix Travis Feb 25, 2019
@miq-bot
Copy link
Member

miq-bot commented Feb 25, 2019

Checked commit ZitaNemeckova@0f087bb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@himdel
Copy link
Contributor

himdel commented Feb 25, 2019

LGTM, confirming we were using 3.1.* until now, so 👍 for continuing :)

The dependency originaly comes from #4895, adding hammer/no

@himdel himdel merged commit e0006c7 into ManageIQ:master Feb 25, 2019
@ZitaNemeckova ZitaNemeckova deleted the downgrade_enzyme branch February 25, 2019 09:04
@himdel himdel added this to the Sprint 106 Ending Mar 4, 2019 milestone Feb 25, 2019
@himdel himdel mentioned this pull request Feb 25, 2019
Closed
@himdel himdel mentioned this pull request Apr 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hammer/no test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZitaNemeckova @miq-bot @himdel @mzazrivec