Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused EmsCommonAngular mixin (replaced by EmsCommon::Angular) #5674

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Remove unused EmsCommonAngular mixin (replaced by EmsCommon::Angular) #5674

merged 1 commit into from
Jun 5, 2019

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Jun 5, 2019

this was moved to mixins/ems_common/angular.rb in #5173

the file is dead now, removing :).

Cc @skateman

…mixin)

this was moved to mixins/ems_common/angular.rb in #5173

the file is dead now, removing
@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2019

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/5ff7fe444fc2b88139b737e2c95a43b8e37d9836 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@martinpovolny martinpovolny added this to the Sprint 113 Ending Jun 10, 2019 milestone Jun 5, 2019
@martinpovolny martinpovolny self-assigned this Jun 5, 2019
@martinpovolny martinpovolny merged commit 32602e1 into ManageIQ:master Jun 5, 2019
@himdel himdel deleted the ems-common-angular branch June 11, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants