Ansible Credential textual summary - show nicer error when credential class is missing API_ATTRIBUTES #5694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class is missing API_ATTRIBUTES it's a fatal error, it should be a fatal error, but since embedded ansible is in the process of being rewritten, maybe it should not be a fatal error quite yet Any credentials need the API_ATTRIBUTES class constant to tell the UI what fields are actually relevent, but when it's missing, we would now show a full textual summary with missing credentials (and a non-flash warning), instead of an error screen.
|
(I don't know whether we should merge this or not, it's just something to fix travis, so that I can start working :).) |
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/348e09041ff38716381d986581c68a6c51974c41 with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Closing in favor of ManageIQ/manageiq#18854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
(sans the green smudge)
It's a fatal error, it should be a fatal error, but since embedded ansible is in the process of being rewritten,
maybe it should not be a fatal error quite yet - comes from ManageIQ/manageiq#18687, Cc @NickLaMuro
Any credentials need the
API_ATTRIBUTESclass constant to tell the UI what fields are actually relevent,but when it's missing, we would now show a full textual summary with missing credentials (and a non-flash warning),
instead of an error screen.
The main point of this PR is to fix travis. How we present the error .. this is a simple way, a flash message would be nicer but we have no mechanism for it on the textual summary endpoint yet.