Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated validate_creds_task #6664

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Remove deprecated validate_creds_task #6664

merged 1 commit into from
Feb 10, 2020

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Feb 8, 2020 •
edited
Loading

Core removal PR: ManageIQ/manageiq#19346

see ManageIQ/manageiq#19512

DEPRECATION WARNING: validate_credentials_task is deprecated and
will be removed from ManageIQ K-release (use verify_credentials_task instead)
(called from block (4 levels) in <top (required)> at
spec/models/mixins/authentication_mixin_spec.rb:293)

"If you want it solved a different way, just give the word" which word might that be exactly anyway, one wonders

@d-m-u d-m-u force-pushed the removing_validate_creds_things branch from a156e61 to de5a974 Compare February 8, 2020 01:39
@miq-bot
Copy link
Member

miq-bot commented Feb 8, 2020

Checked commit d-m-u@de5a974 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Feb 10, 2020
@mzazrivec mzazrivec added this to the Sprint 130 Ending Feb 17, 2020 milestone Feb 10, 2020
@mzazrivec mzazrivec merged commit 2f00acf into ManageIQ:master Feb 10, 2020
@d-m-u d-m-u deleted the removing_validate_creds_things branch February 10, 2020 12:07
@agrare
Copy link
Member

agrare commented Feb 10, 2020

Hey, this breaks at least the VMware InfraManager verification. I don't think we're ready to move 100% over to DDF and the new verify_credentials_task method yet. cc @skateman

@skateman
Copy link
Member

Yeah, this broke a lot of stuff.

@skateman
Copy link
Member

#6650 (comment)

agrare added a commit to agrare/manageiq-ui-classic that referenced this pull request Feb 10, 2020
@agrare
Revert "Merge pull request ManageIQ#6664 from d-m-u/removing_validate…
3fb2301 
…_creds_things"

This reverts commit 2f00acf, reversing
changes made to 60a70b2.
@agrare agrare mentioned this pull request Feb 10, 2020
Merged
@agrare
Copy link
Member

agrare commented Feb 10, 2020

Revert: #6666

@Fryguy
Copy link
Member

Fryguy commented Feb 10, 2020

See also ManageIQ/manageiq#18818

@agrare Can we get rid of the deprecation warning...this is like the 3rd time someone has tried to remove it before it was ready.

h-kataria added a commit that referenced this pull request Feb 10, 2020
@h-kataria
Merge pull request #6666 from agrare/revert_removing_validate_creds_t…
da80d33 
…hings

Revert #6664 to fix credential validation
@agrare
Copy link
Member

agrare commented Feb 10, 2020

👍 yeah will do

@agrare agrare mentioned this pull request Feb 10, 2020
Merged
@mzazrivec
Copy link
Contributor

Hey, this breaks at least the VMware InfraManager verification

Ops, sorry about the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzazrivec mzazrivec mzazrivec approved these changes

Assignees

@mzazrivec mzazrivec

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@d-m-u @miq-bot @agrare @skateman @Fryguy @mzazrivec