Replace cloud provider forms with an API-driven DDF approach

[skateman]

Depends on: ManageIQ/manageiq-api#741 ManageIQ/manageiq-api#830
Replaces: #6402
Parent issue: ManageIQ/manageiq#18818

The following providers are already supported:

• Amazon - Implement a method that allows editing with incoming DDF params manageiq-providers-amazon#599
• GCE
• OpenStack - Adjusted DDF schema for create/edit and validation manageiq-providers-openstack#568
• vCloud - Adjusted DDF schema for create/edit and validation manageiq-providers-vmware#561
• Azure
• Azure stack - Adjusted DDF schema and validation manageiq-providers-azure_stack#26

Known issues:

• Initial value loading when changing between types - Merging passed initialValues from the schema and from props data-driven-forms/react-forms#332
• Initial value prioritization when editing - Update DDF to the latest 1.30.0 version #6780
• Schema change for determining endpoint/authentication types NOT NECESSARY

@miq-bot add_label react, enhancement, compute/cloud

[Hyperkid123]

So far so good. I am excited about the tests 😉

[skateman]

I'm sure I'm not able to write tests, so I will rely on the experts 😁 @brumik can you help me in a followup pr?

[brumik]

I think so :)

[skateman]

When adding a new one..

Search... is wrong as that select is not searchable.
But it's not in providers-amazon, it doesn't say Search, it seems to be a ddf default - maybe we should override the default to Choose? (globally in miq ddf configuration I mean)

This is not related to this PR, also happens on master:

It just needs a placeholder property in each provider. Gonna go through them all, not related to this PR.

EDIT: maybe it's better if we set it globally, but still not related to this PR

[Hyperkid123]

@skateman you can use https://data-driven-forms.org/renderer/global-component-props if you want to override global props.

[skateman]

@skateman you can use https://data-driven-forms.org/renderer/global-component-props if you want to override global props.

That's great, but does this work on DDFv1?

[Hyperkid123]

@skateman oh right sorry. No its v2 feature. I keep forgetting.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[h-kataria]

@skateman

• Add new Provider form should have "Add/Cancel" buttons instead of "Save/Reset/Cancel", to be consistent with other forms in the product
• Flash message is missing when after changes in the Edit provider form are Reset
• Just wondering if form buttons should be disabled while Validation is in process on Edit provider form.

[skateman]

@skateman

• Add new Provider form should have "Add/Cancel" buttons instead of "Save/Reset/Cancel", to be consistent with other forms in the product

Fixed

• Flash message is missing when after changes in the Edit provider form are Reset

I'm not entirely sure why is this necessary, the reset doesn't do a server roundtrip anymore so there's no way it would fail due to a server error.

• Just wondering if form buttons should be disabled while Validation is in process on Edit provider form.

Maybe it's possible to do it, but I'd like to take it into a separate PR and especially after we are on DDFv2.

[h-kataria]

@skateman

• Add new Provider form should have "Add/Cancel" buttons instead of "Save/Reset/Cancel", to be consistent with other forms in the product

Fixed

• Flash message is missing when after changes in the Edit provider form are Reset

I'm not entirely sure why is this necessary, the reset doesn't do a server roundtrip anymore so there's no way it would fail due to a server error.

• Just wondering if form buttons should be disabled while Validation is in process on Edit provider form.

Maybe it's possible to do it, but I'd like to take it into a separate PR and especially after we are on DDFv2.

I feel the Save should not be allowed while credentials are being validated, that will give user an opportunity to change/fix them in case validation failed. Let's do the disabling of Save button in a separate PR

I am not sure about removing the Reset flash message, we do have that in other DDF forms tho, is there a plan to remove it from all new forms?

[skateman]

Okay, I'll put it there...but will create an issue about getting rid of this.

[miq-bot]

Checked commits skateman/manageiq-ui-classic@48e04b3~...4e9d756 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
3 files checked, 3 offenses detected

app/views/ems_cloud/edit.html.haml

• ⚠️ - Line 1 - Layout/TrailingBlankLines: Final newline missing.
• ⚠️ - Line 1 - Line is too long. [190/160]

app/views/ems_cloud/new.html.haml

• ⚠️ - Line 3 - Layout/TrailingBlankLines: Final newline missing.