Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EmsContainerController: use allows instead of expect #7052

Merged
merged 1 commit into from
May 18, 2020
Merged

EmsContainerController: use allows instead of expect #7052

merged 1 commit into from
May 18, 2020

Conversation

mzazrivec
Copy link
Contributor

Probably a better fix for #7051

@mzazrivec mzazrivec added the test label May 18, 2020
@mzazrivec mzazrivec requested a review from skateman May 18, 2020 13:52
skateman
skateman approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@miq-bot
Copy link
Member

miq-bot commented May 18, 2020

Checked commit mzazrivec@746f0e9 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@skateman skateman merged commit a50e9b6 into ManageIQ:master May 18, 2020
@skateman skateman self-assigned this May 18, 2020
@skateman skateman linked an issue May 18, 2020 that may be closed by this pull request
Broken travis from other repos #4921
Closed
@skateman skateman removed a link to an issue May 18, 2020
Broken travis from other repos #4921
Closed
@mzazrivec mzazrivec deleted the use_allow_instead_of_expect_in_ems_container_controller branch May 18, 2020 14:18
@mzazrivec mzazrivec mentioned this pull request May 20, 2020
Merged
simaishi pushed a commit that referenced this pull request May 20, 2020
@skateman @simaishi
Merge pull request #7052 from mzazrivec/use_allow_instead_of_expect_i…
f1fae0d 
…n_ems_container_controller

EmsContainerController: use allows instead of expect
(cherry picked from commit a50e9b6)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit f1fae0d710cfb34ef70f856b00953aecc71b2607
Author: Halász Dávid <skateman@users.noreply.github.com>
Date:   Mon May 18 16:11:56 2020 +0200

    Merge pull request #7052 from mzazrivec/use_allow_instead_of_expect_in_ems_container_controller

    EmsContainerController: use allows instead of expect
    (cherry picked from commit a50e9b676329a334bcb408038530c82e2a9681a8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@skateman skateman

Labels
jansa/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzazrivec @miq-bot @simaishi @skateman