Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old angular ansible tower form with a react based DDF #7176

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

skateman
Copy link
Member

@skateman skateman commented Jul 2, 2020

As this provider screen is explorer-based, it has some issues with redirects after creating/editing. The redirect after an API call requires a permalink to a given provider, which is not doable here. Therefore, as long as this screen is not de-explorerized, any operation will redirect back to the providers list screen.

Parent issue: ManageIQ/manageiq#18818
Depends on: ManageIQ/manageiq-providers-ansible_tower#228 ManageIQ/manageiq-providers-ansible_tower#229

@skateman skateman changed the title [WIP] Replace old angular ansible tower form with a react based DDF Replace old angular ansible tower form with a react based DDF Jul 23, 2020
@miq-bot miq-bot removed the wip label Jul 23, 2020
@miq-bot
Copy link
Member

miq-bot commented Jul 23, 2020

Checked commit skateman@5312c9d with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby25, which recognizes
warning: 2.5.8-compliant syntax, but you are running 2.5.7.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@skateman
Copy link
Member Author

@h-kataria this is ready for review

@h-kataria
Copy link
Contributor

h-kataria commented Jul 31, 2020

verified in UI.
@skateman Noticed 2 differences from old version of the form in flash messages.

  • Flash message is missing when pressing Reset button on edit Provider form, need to open a separate issue to make it consistent among all DDF forms.
  • When pressing Cancel button on edit form, record name/display name is missing from the flash message

@skateman
Copy link
Member Author

@h-kataria are these issues happening only on the infra provider forms, or other ones too? If yes, please create separate issues as the problem is global and not in the context of this PR.

@h-kataria
Copy link
Contributor

@h-kataria are these issues happening only on the infra provider forms, or other ones too? If yes, please create separate issues as the problem is global and not in the context of this PR.

opened #7244

@h-kataria h-kataria merged commit 9375df1 into ManageIQ:master Jul 31, 2020
@skateman skateman deleted the automation-manager-ddf branch August 1, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants