Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions #8098

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Switch to GitHub Actions #8098

merged 1 commit into from
Feb 6, 2022

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 6, 2022

No description provided.

@Fryguy Fryguy mentioned this pull request Feb 6, 2022
Closed
@Fryguy Fryguy changed the title Switch to GitHub Actions [WIP] Switch to GitHub Actions Feb 6, 2022
Fryguy
Fryguy commented Feb 6, 2022
View reviewed changes
.github/workflows/ci.yaml
ci:
runs-on: ubuntu-latest
strategy:
fail-fast: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove this before un-WIP

Fryguy
Fryguy commented Feb 6, 2022
View reviewed changes
bin/ci/after_script.sh
echo "travis_fold:start:YARN_LOCK"
yarn list
echo "travis_fold:end:YARN_LOCK"
fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm dropping this file entirely, as we should do any diagnostic stuff like this in core's plugin setup.

@miq-bot miq-bot added the wip label Feb 6, 2022
Fryguy
Fryguy commented Feb 6, 2022
View reviewed changes
bin/setup Outdated
Comment on lines 11 to 14
if %w[spec:compile spec:javascript spec:jest].include?(ENV["TEST_SUITE"])
puts "\n== Updating UI assets =="
ManageIQ::Environment.update_ui
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is unique for ui classic, if you compare this PR to other GitHub Actions PRs I've made.

@Fryguy Fryguy closed this Feb 6, 2022
@Fryguy Fryguy reopened this Feb 6, 2022
@Fryguy Fryguy changed the title [WIP] Switch to GitHub Actions Switch to GitHub Actions Feb 6, 2022
@Fryguy Fryguy changed the title Switch to GitHub Actions [WIP] Switch to GitHub Actions Feb 6, 2022
@Fryguy Fryguy force-pushed the github_actions branch 3 times, most recently from c81d56d to 8623200 Compare February 6, 2022 17:36
@Fryguy
Copy link
Member Author

Fryguy commented Feb 6, 2022

debride went green, but it has this error: https://github.com/ManageIQ/manageiq-ui-classic/runs/5084773289?check_suite_focus=true#step:8:9. I wonder if it ever worked.

@Fryguy Fryguy force-pushed the github_actions branch 5 times, most recently from 5cf2359 to 411d002 Compare February 6, 2022 20:25
@miq-bot
Copy link
Member

miq-bot commented Feb 6, 2022

Checked commits Fryguy/manageiq-ui-classic@d096c20~...724184d with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy changed the title [WIP] Switch to GitHub Actions Switch to GitHub Actions Feb 6, 2022
@Fryguy
Copy link
Member Author

Fryguy commented Feb 6, 2022

Ok, I got everything to a point where I can't figure it out anymore. Everything passes except jest. I am getting a can't find module "node-fetch", so naturally I tried adding node-fetch, but then it complains about node:http and I don't understand anything. @kavyanekkalapu the plan is we will merge this and fix on master tomorrow.

#8098 (review) (removing fail-fast: false) still needs to be done, but from a testing standpoint, it's easier to keep fail-fast on, so I'm leaving it for now, and then once we are green we can remove that line.

@miq-bot miq-bot removed the wip label Feb 6, 2022
@chessbyte chessbyte merged commit b387527 into ManageIQ:master Feb 6, 2022
@Fryguy Fryguy deleted the github_actions branch February 6, 2022 21:19
@kavyanekkalapu
Copy link
Member

@Fryguy please merge #8094 to fix node-fetch issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies developer test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fryguy @miq-bot @kavyanekkalapu @chessbyte