Fix rails 6.1 errors is now array warnings

[jrafanie]

Fixes this warning in several places in the test suite:

  In Rails 6.1, `errors` is an array of Error objects,
  therefore it should be accessed by a block with a single block
  parameter like this:

  person.errors.each do |error|
    attribute = error.attribute
    message = error.message
  end

  You are passing a block expecting two parameters,
  so the old hash behavior is simulated. As this is deprecated,
  this will result in an ArgumentError in Rails 7.0.

[Fryguy]

Is this code Rails 6.0 compatible, or will it have to be reverted if we need to revert 6.1?

[jrafanie]

Is this code Rails 6.0 compatible, or will it have to be reverted if we need to revert 6.1?

If I can ever get spec:javascript to fail locally and then pass in CI, I'll look to see if 6.0 will work with the array assumption. My hunch is this is a rails 7 change and we'd need to revert to go back to 6.0

[kbrock]

Is this code Rails 6.0 compatible, or will it have to be reverted if we need to revert 6.1?

This is not rail 6.0 friendly.
It is a change that is available in 6.1 (optional)
and then mandatory in 7.0

[miq-bot]

Checked commit jrafanie@3f3815e with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
24 files checked, 1 offense detected

app/controllers/application_controller/ci_processing.rb

• ❗ - Line 164, Col 44 - Style/SymbolProc - Pass &:message as an argument to collect instead of a block.

[kbrock]

This is low risk, but I said Oparin/no
If we are worried about backport conflicts, then it may make sense to backport this

[Fryguy]

Don't put oparin/no at the moment only because it will be backported anyway after we merge master into oparin after the stabilization period.