Only show visible custom attributes #881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enoodle
force-pushed
the
only_show_visible_custom_attributes
branch
2 times, most recently
from
07ae9e8 to
6287e0a
Compare
himdel
reviewed
Apr 3, 2017
| end | ||
|
|
||
| def textual_miq_custom_attributes | ||
| attrs = @record.custom_attributes.where(:visible => true) |
There was a problem hiding this comment.
@record.miq_custom_attributes, not custom_attributes
There was a problem hiding this comment.
Also, the filtering may be better done in custom_attribute_mixin.rb
enoodle
force-pushed
the
only_show_visible_custom_attributes
branch
from
6287e0a to
943c3ea
Compare
|
This pull request is not mergeable. Please rebase and repush. |
enoodle
force-pushed
the
only_show_visible_custom_attributes
branch
from
943c3ea to
4293f5e
Compare
enoodle
force-pushed
the
only_show_visible_custom_attributes
branch
from
4293f5e to
afdccc3
Compare
|
Checked commit enoodle@afdccc3 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@enoodle if relevant can you fix travis? Thanks. |
|
@simon3z This needs the base PR (ManageIQ/manageiq#14611) to be merged for the tests to be green. |
|
With the move to use options per provider, this is not needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on ManageIQ/manageiq#14611, This will only show custom attributes where
visible => true.Due to CodeClimate's insistence I had to also create a mixin for visible custom attributes and I also included the redact function in it.