Fixed optimization table translations #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffibm
reviewed
Oct 10, 2023
| @@ -5,12 +5,12 @@ const convertHeader = (headerItems) => headerItems.map((item) => ({ key: item[0] | |||
|
|
|||
| /** Attributes needed for a button. */ | |||
| const buttonData = (item) => ({ | |||
| alt: 'Queue Report', | |||
| alt: `${__('Queue Report')}`, | |||
There was a problem hiding this comment.
Hey @GilbertCherrie , can't we just use like this - __('Queue Report')
There was a problem hiding this comment.
@jeffibm Should be fixed now if you can review again
GilbertCherrie
force-pushed
the
fix_optimization_table_translations
branch
from
d64e3e2 to
fc351e4
Compare
|
Checked commit GilbertCherrie@fc351e4 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
Skipping backport to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the optimization table on the Overview > Optimization page missing translations for the 'Queue Report' button.
Before:
After:
