Change ui to display max alert description length

[kbrock]

Displaying the database length limit in the ui
(Just trying to get pen tests fixed)

I thought the model's values would be displayed in the UI.
Looks like this is manually entered in 2 places

ManageIQ/manageiq#21921

These limits are arbitrary. We changed a limit of 50 to 100 and then to 255
The UI was not fixed. So testers trying 70 (larger than 50) thought that no limit took place

This fixes the UI so testers can ensure the limits are met

Before

After

[kbrock]

It is tricky to see the changes.
Here is a before and after.
Sorry it includes the explorer to show the values

[Fryguy]

LGTM but tests are failing

[jeffibm]

Hey @kbrock , running the yarn run jest -u will update the snapshot and will fix the problem...

[kbrock]

update:

• rebase
• updated jest test

[miq-bot]

Checked commit kbrock@82f61ed with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

[Fryguy]

Skipping backport to quinteros, because it is already in the branch.

[Fryguy]

@kbrock A conflict occurred during the backport of this pull request to morphy.

If this pull request is based on another pull request that has not been marked for backport, add the appropriate labels to the other pull request. Otherwise, please create a new pull request direct to the morphy branch in order to resolve this.

Conflict details:

* Unmerged path app/javascript/components/miq-alert-set-form/miq-alert-set-form.schema.js
* Unmerged path app/javascript/spec/miq-alert-set-form/__snapshots__/miq-alert-set-form.spec.js.snap

[Fryguy]

@jeffibm We need some help backporting this change to morphy. The morphy code is from before the react conversion from what I can tell, and app/javascript/components/miq-alert-set-form doesn't exist on morphy.

[kbrock]

The main goal of this change is to change the messaging on the screen.

[kbrock]

ok, I vote we do not backport this UI change.
I think this is not an ui issue in morphy.

• We did backport a change to the model so the back end caped at 255
• In React, we updated the UI to say the cap was 255 (used to say 50)
• From what I can tell, the old UI said the cap was 255 characters

refs:

• https://github.com/ManageIQ/manageiq-ui-classic/blob/morphy/app/views/miq_alert_set/_form.html.haml#L11
• https://github.com/ManageIQ/manageiq-ui-classic/blob/morphy/app/helpers/view_helper.rb#L9

@jeffibm Based upon these links, does this sound right to you?

[Fryguy]

Cool - thanks for digging in @kbrock !

[jeffibm]

ok, I vote we do not backport this UI change. I think this is not an ui issue in morphy.

• We did backport a change to the model so the back end caped at 255
• In React, we updated the UI to say the cap was 255 (used to say 50)
• From what I can tell, the old UI said the cap was 255 characters

refs:

• https://github.com/ManageIQ/manageiq-ui-classic/blob/morphy/app/views/miq_alert_set/_form.html.haml#L11
• https://github.com/ManageIQ/manageiq-ui-classic/blob/morphy/app/helpers/view_helper.rb#L9

@jeffibm Based upon these links, does this sound right to you?

yes, the old UI had 255 characters as the limit for Description.